-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for a template for evaluating other sotas #4
Comments
|
I notice that for iCarl whose "args.wrap_first_task_model" is True, the value of 'skip_to_the_post' is always True in framework_train.py, which will skip the parts including manager.best_model_path initialization. I am not sure if my usage above is correct. |
Since the iCarl implementation in CLsurvey frame is modified using the implementation of GEM, both GEM and iCarl methods result in errors. It seems that the problematic part is in the poststep() of both GEM and iCarl in method.py. As the flag 'skip_to_post' is always True (specified as a class attribution), it will get into the poststep() function immediatly. However, the lr/ heurisric_exp_dir / best_model_path attributions of manager instance are initialized in the PHASE 1 & 2 in the hyperparam-framework. |
Thanks for the share of the CL study frame! However I wonder how to use iCarl with the framework. I have modified the main_tinyimagenet.sh file via adding static_hyperparams term to the arguments, but still got several errors. Could you please provide a shell file for running iCarl ? Appreciate that.
The text was updated successfully, but these errors were encountered: