Receive a canvas instead of a container #73
Replies: 4 comments 1 reply
-
Use css for the win. The mechanics would be to bump the threejs version to 1.1.0 if compatibility and 2.0.0 if no compatibility. It looks like we don't separate an API version with the version of the package name itself. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
Thinking well, it should receive the container as we need to add the tick labels to the container, but the CSS configuration should be in the container, not in mathics-threejs-backend. |
Beta Was this translation helpful? Give feedback.
-
Implemented in PR #101. |
Beta Was this translation helpful? Give feedback.
-
Currently
drawGraphics3d
receives up to 4 parameters, where the last 2 aremaxSize
andinnerWidthMultiplier
.This is very odd, I think this shouldn't be done this way because this way we don't allow things like width != height, parent-element percentage width, CSS media queries, ... and make the window resize slower even when the canvas isn't resized.
maxSize
andinnerWidthMultiplier
would be replaced by a bit of CSS.Current version:
Proposal:
I could add a "conversion" in the translation layer to keep the backward compatibility.
@rocky @axkr your thoughts?
Beta Was this translation helpful? Give feedback.
All reactions