Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially rationalize badge implementation #780

Open
simonziegler opened this issue Dec 26, 2022 · 0 comments
Open

Potentially rationalize badge implementation #780

simonziegler opened this issue Dec 26, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@simonziegler
Copy link
Member

Badge bearing components all repeat the same minor code to implement BadgeValue and BadgeExited along with detecting changes to both in OnParametersSetAsync. It would be nice to find a way to eliminate this repetition. We decided not to add further inheritance because the inheritance tree would become too complex.
@simonziegler simonziegler added the bug Something isn't working label Dec 26, 2022
@simonziegler simonziegler added this to the Backlog milestone Dec 26, 2022
@MarkStega MarkStega added enhancement New feature or request and removed bug Something isn't working labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@MarkStega @simonziegler