Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots #41

Open
devMikeFrancis opened this issue Mar 15, 2024 · 4 comments
Open

Snapshots #41

devMikeFrancis opened this issue Mar 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@devMikeFrancis
Copy link

The QRC JSON command issued for Snapshots appears to be sending Component.Set method instead of Snapshot.Set methods.

Following the API guide for a Snapshot named "MySpecialBank" with a single bank:

{ "jsonrpc": "2.0", "method": "Snapshot.Load", "params": { "Name": "MySpecialBank", "Bank": 1, "Ramp": 8.5 }, "id": 1234 }

What the drivers are sending (from debug output):

{ "jsonrpc": "2.0", "id": "{\"app\":\"crestron\",\"caller\":\"MySpecialBank\",\"valueType\":\"value\",\"method\":\"load_1\",\"value\":1.0,\"stringValue\":\"1\",\"position\":0.0}", "method": "Component.Set", "params": { "Name": "MySpecialBank", "Controls": [ { "Name": "load_1", "Value": 1.0 } ] } }

which returns that the component does not exist.

@MatKlucznyk
Copy link
Owner

The Snapshot commands did not exist when I wrote these modules. Have you tried naming the snapshot component in the designer window/properties (depending on the version of qsys you are using)?

Example of a non-named snapshot component and a named one:
image

@devMikeFrancis
Copy link
Author

It looks like it is possible to rename the component like you showed and it will function with the Component method, you just loose the ability to dynamically assign ramp time that you get with using the dedicated method. I am not sure if there are any other differences between the two.

@MatKlucznyk
Copy link
Owner

MatKlucznyk commented Mar 16, 2024

Im going to assign this as an enhancement. I'll update this thread if its feasible or not.

@MatKlucznyk MatKlucznyk added the enhancement New feature or request label Mar 16, 2024
@astingen
Copy link
Contributor

astingen commented Apr 1, 2024

So, I've used the Snapshot.Set methods in my other qsys modules. (They were undocumented at the time, and we had to call qsys).

One downside of them, there's no feedback with them like the component has. At least, not from what I've found. Which is quite handy for some scenarios (camera presets for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants