-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Borefield
class
#210
Comments
I'm currently not sure how to make an instance a callable method like above. If
|
I had started the development a while ago on my branch. I also have uncommitted changes. I had the pygfunction/pygfunction/boreholes.py Lines 240 to 252 in 0beb558
The main objective of implementing a |
Many functions in the
heat_transfer
andgfunction
modules necessitate to generate arrays of borehole parameters (i.e.H
,D
,r_b
,x
,y
,tilt
,orientation
) from lists of boreholes. This generates multiple instances of duplicate and not very readable code.The new
Borefield
class will replace lists of boreholes within the modules. Anytime a user provides a list of boreholes, this list will be used to generate aBorefield
object. Alternatively,Borefield
objects can be provided as input.To preserve current behavior, the following should be considered (for an instance
borefield
of theBorefield
class):borefield[i]
should return thei
-th boreholeborefield[i0:i1]
should return an instance of theBorefield
class formed by boreholesi0
throughi1-1
.To simplify the code, the
Borefield
class will:Borehole
class to evaluate, e.g., distance vectors and arrays. An additional parameterouter
can be included to evaluate distance vectors (outer=False
) and arrays (outer=True
).borefield.H
returns an array of borehole lengths.The text was updated successfully, but these errors were encountered: