Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default parameters for the evaluation of g-functions #158

Closed
MassimoCimmino opened this issue Nov 7, 2021 · 0 comments · Fixed by #161
Closed

Update default parameters for the evaluation of g-functions #158

MassimoCimmino opened this issue Nov 7, 2021 · 0 comments · Fixed by #161
Assignees
Milestone

Comments

@MassimoCimmino
Copy link
Owner

#146 introduced the 'equivalent' solver which significantly speeds up calculations.
#135 introduced non-uniform discretization of finite line sources. This decreases calculation times (due to the lowered required number of segments) and increases accuracy.

Currently, the default solver is 'similarities' and the default discretization is nSegments=12 with a uniform discretization.

This issue is to possibly update the default parameters to use the 'equivalent' solver and a non-uniform discretization. nSegments=8 and the utilities.segment_ratios() function to define the discretization seem to produce good results based on #136.

Default parameters can be revised again after #153.

Required tasks are to update default parameters, examples, and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant