Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US EPA API is back #214

Closed
tsufz opened this issue Feb 16, 2023 · 4 comments
Closed

US EPA API is back #214

tsufz opened this issue Feb 16, 2023 · 4 comments

Comments

@tsufz
Copy link
Member

tsufz commented Feb 16, 2023

Hi all, the US EPA API is back. See https://api-ccte.epa.gov/docs/chemical.html. However, an APIkey is required to retrieve the data. Hence, we need to decide, if people should use their own APIkey (to be implemented also in RMassBank) or if we automatically infuse US EPA data (e.g. DTXSID) in the records during submission?

@sneumann
Copy link
Member

Hi, I recommend to close the issue here and move to MassBank-web or rather RMassBank. Currently, MassBank-web does no data manipulation upon import. Yours, Steffen

@schymane
Copy link
Member

Not sure why it would belong more on MassBank-web than in MassBank-data - as this is something that would enhance data records and could be screened / added as part of validation (similar to e.g. adding missing InChIKeys if SMILES and InChI are available).
Having it here (MassBank-data) is a more central solution than RMassBank, as we are getting increasing contributions via their own workflows and not just RMassBank?

@tsufz
Copy link
Member Author

tsufz commented Feb 20, 2023

Yes, @sneumann is right. This is a validator issue. I am always a friend of central, automated services rather than extra work in RMassBank.

@tsufz
Copy link
Member Author

tsufz commented Feb 20, 2023

Discussion moved to MassBank/MassBank-web#372.

@tsufz tsufz closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants