Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StringPool for namingstrategies #267

Open
4 tasks
Marvin-Brouwer opened this issue Feb 2, 2023 · 0 comments
Open
4 tasks

Implement StringPool for namingstrategies #267

Marvin-Brouwer opened this issue Feb 2, 2023 · 0 comments
Labels
enhancement New feature or request Low Prio Low priority
Milestone
net8

Comments

@Marvin-Brouwer
Copy link
Owner

Is your feature request related to a problem? Please describe.
A lot of propertynames are duplicate and the namingstrategy doesn't change during (de)serialization.
It's probably smart to use a stringpool where the namingstrategies are called.

Describe the solution you'd like

  • Create a namingstrategy helper that accepts a span and a stringpool
  • Add stringpool reference to settings and pass to namingstrategies
  • Use the helper in namingstrategies
  • Measure measure measure

Additional context
https://youtu.be/OjFuBMhJmr4
@Marvin-Brouwer Marvin-Brouwer added enhancement New feature or request Low Prio Low priority labels Feb 2, 2023
@Marvin-Brouwer Marvin-Brouwer added this to the net8 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Low Prio Low priority
Projects
None yet
Milestone
net8
Development

No branches or pull requests
1 participant
@Marvin-Brouwer