Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions testlogger incorrectly configured #131

Open
Marvin-Brouwer opened this issue Apr 19, 2022 · 2 comments
Open

Github actions testlogger incorrectly configured #131

Marvin-Brouwer opened this issue Apr 19, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Help wanted

Comments

@Marvin-Brouwer
Copy link
Owner

Package+Version:
All 1.0.0

Framework version:
All

Describe the bug
The test logger is logging to GithubActions logger but it's not installed.

To Reproduce
Steps to reproduce the behavior:

  1. Run CI pipeline.

Expected behavior
We'd expect to see code comments on faillures.
And a report.

Screenshots
N/A

Additional context
Run dotnet add package GitHubActionsTestLogger on setup dotnet command.
@Marvin-Brouwer Marvin-Brouwer added the bug Something isn't working label Apr 19, 2022
@Marvin-Brouwer Marvin-Brouwer added help wanted Extra attention is needed good first issue Good for newcomers labels May 12, 2022
@Marvin-Brouwer
Copy link
Owner Author

The GitHubActionsTestLogger is installed in the test projects.
So maybe something else is incorrectly configured

@Marvin-Brouwer Marvin-Brouwer changed the title Github actions incorrectly configured Github actions testlogger incorrectly configured May 17, 2022
@Marvin-Brouwer
Copy link
Owner Author

It appears that this logger does log out the results in the summary.
The only thing that doesn't seem to work is the in-code comments

@Marvin-Brouwer Marvin-Brouwer removed this from the Additional features release milestone May 20, 2022
@Marvin-Brouwer Marvin-Brouwer added this to the Help wanted milestone Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Help wanted
Development

No branches or pull requests
1 participant
@Marvin-Brouwer