Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the implementation of beam-search seem not to be right #30

Open
cyzhangAThit opened this issue Aug 30, 2017 · 0 comments
Open

the implementation of beam-search seem not to be right #30

cyzhangAThit opened this issue Aug 30, 2017 · 0 comments

Comments

@cyzhangAThit
Copy link

in the function "get_predicted_sentence" in the lib/seq2seq_model_utils.py, you loop the dptr and pass a new cand["dec_inp"] to the function model_step. However, when the flag "forward_only" is set to True, any new cand["dec_inp"] doesn't work according to the function "attention_decoder" in the lib/seq2seq.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyzhangAThit