Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createMarketSale have nftContractAddress as argument #4

Open
ghettoaliens opened this issue Jul 2, 2022 · 1 comment
Open

createMarketSale have nftContractAddress as argument #4

ghettoaliens opened this issue Jul 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ghettoaliens
Copy link

Hello, first of all thank you very much for contributing with a marketplace code that people can use as an example.

And secondly, i think that the createMarketSale would have to get the contract address directly from the mapping array marketItemIdToMarketItem not as a function argument.

Because it could allow an external user to shop a token through a different contract address, not the address of the market item.

@Markkop Markkop added the enhancement New feature or request label Jul 6, 2022
@Markkop
Copy link
Owner

Markkop commented Jul 6, 2022

Hey, @ghettoaliens! You're right, this improvement would give this contract greater versatility.
I might add this feature when I have time, but would you like to open a Pull Request with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants