Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ST3 #6

Closed
chronossc opened this issue May 11, 2013 · 24 comments
Closed

Support ST3 #6

chronossc opened this issue May 11, 2013 · 24 comments

Comments

@chronossc
Copy link

Hello. This is the theme I love, however it not works in Sublime Text 3 builds.

Can you fix errors?

@craig-jennings
Copy link

What errors are you seeing? I just installed this theme with ST3 and there were no problems.

@natecox
Copy link

natecox commented Aug 4, 2013

I'm not getting any errors per say, but I am seeing minor breakages on the nightly from ST3.

First thing that comes to mind is the tab switcher arrows at the top left of the open file.

@Raynos
Copy link
Contributor

Raynos commented Aug 19, 2013

👍 Can you add it to ST3 package control ?

@williamhc
Copy link

I am getting this visual issue in ST3 when opening the command palette:
screen shot 2013-08-20 at 9 59 50 am

@Raynos
Copy link
Contributor

Raynos commented Aug 20, 2013

I'm getting the same visual issue.

@steinmb
Copy link

steinmb commented Aug 22, 2013

Try also testing your packages at http://www.caniswitchtosublimetext3.com and this theme was tagged as not supporting ST3.

@LOQUILLO
Copy link
Contributor

hi @EleazarCrusader you could fix errors and add support for ST3

@jonstuebe
Copy link

+1 Would love to see ST3 support. What all goes into upgrading the theme. I would be on board with helping.

@LOQUILLO
Copy link
Contributor

nexus_st3
nexus_2_st3

Hi, this theme I have working in ST3 with no issues. I dunno why was givingme errors, but in a fressh and clean installation of ST3 all is working ok. I had fixed little cosmetic bug.

@LOQUILLO
Copy link
Contributor

To configure Sublime Text 3 to use the theme:

  • Open your User Settings Preferences file Sublime Text 3 -> Preferences -> Settings - User
  • Add (or update) your theme entry to be "theme": "Nexus.sublime-theme"

That's all.

@LOQUILLO
Copy link
Contributor

This is the changes:
// PANEL BACKGROUNDS
// =========================================================
// - Bottom panel background
{
"class": "panel_control",
"layer0.texture": "Theme - Nexus/assets/panel-bg.png",
"layer0.inner_margin": [4, 4, 4, 4],
"layer0.opacity": 1.0
},

//  - Quick panel background
{
    "class": "overlay_control",
    "layer0.texture": "Theme - Nexus/assets/default/overlay-bg.png",
    "layer0.inner_margin": [10, 5, 10, 10],  // left, top, right, bottom
    "layer0.opacity": 1.0,
    "layer1.opacity": 0, // HIDDEN
    "layer2.opacity": 0,
    "content_margin": [11, 8, 11, 17]
},

@LOQUILLO
Copy link
Contributor

This is the line fixed:
"layer0.inner_margin": [10, 5, 10, 10], // left, top, right, bottom

The old is:
"layer0.inner_margin": [10, 5, 10, 20], // left, top, right, bottom

I had added this line:
"layer2.opacity": 0,

The original Nexus.sublime-theme don't have it

@LOQUILLO
Copy link
Contributor

I had tested that put Nexus.sublime-theme file into ~\Sublime Text 3\Packages\User is working all ok, if you wanna to do change to original theme file could it in there.

@LOQUILLO
Copy link
Contributor

Hi @chronossc @natecox @Raynos @williamhc @steinmb @jonstuebe, I think that all is fixed now, test my fix.

@Raynos
Copy link
Contributor

Raynos commented Apr 30, 2014

@LOQUILLO Raynos@1a67611

and https://github.com/Raynos/dotfiles/tree/master/.config/sublime-text-3/Packages

I applied your fix to my branch and then installed that package manually in my dotfiles.

I can confirm that it renders properly now.

Thank you very much for the fix!

@Raynos
Copy link
Contributor

Raynos commented Apr 30, 2014

@LOQUILLO do you want to make a PR on this repo or shall I do it ?

@Raynos
Copy link
Contributor

Raynos commented Apr 30, 2014

@LOQUILLO btw awesome work :)

@LOQUILLO
Copy link
Contributor

Hi @Raynos, you can do it, but don't forget mention me.

@MarkHMorrison
Copy link
Owner

Installed the pull request. Package control should update on its own.

@MarkHMorrison
Copy link
Owner

Thanks for working on it. I've been too swamped with life issues to get back into it.

@LOQUILLO
Copy link
Contributor

LOQUILLO commented May 1, 2014

Hi @Raynos which is the next sublime-theme for fix, I have free time for help.

@Raynos
Copy link
Contributor

Raynos commented May 1, 2014

@LOQUILLO I've been trying to get gitgutter to colorize properly in my themes.

I had an open comment here jisaacks/GitGutter#118 (comment)

I think i have to either update my theme (nexus-theme) or my color theme ( https://github.com/Benvie/JavaScriptNext.tmLanguage ) to have the gitgutter styling. I think it's my color theme that needs updating. Although I think I can try this myself

@LOQUILLO
Copy link
Contributor

LOQUILLO commented May 1, 2014

Hi @Raynos I could post my custom sublime-themes, I personally too, use different color scheme for differents languages, somelike CSS files have his own CSS.tmTheme, HTML file with his own HTML.tmTheme, maybe it can help you for solve gitgutter problems.

@LOQUILLO
Copy link
Contributor

LOQUILLO commented May 1, 2014

Hi @Raynos, GitGutter was working somedays in my ST2 but after, mysteriously anymore, I had disabled JSHint, JSLint, CSSLint, SublimeLinter, but GitGutter never back to work. In these days can try again for fix this issue. You check wich Packages can is blocking GitGutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants