Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check third party libraries #9

Open
MarcusRainbow opened this issue Jun 28, 2018 · 8 comments
Open

Check third party libraries #9

MarcusRainbow opened this issue Jun 28, 2018 · 8 comments

Comments

@MarcusRainbow
Copy link
Owner

We rely on rand for random numbers. Is this as good as Mersenne Twister? (If not, it would be better to implement Mersenne Twister.)

We rely on statrs for Normal distribution functions. How accurate are these? It really matters for far out of the money options how good the cumulative normal function is in the wings.

@petr-tik
Copy link

Just found this library (amazing work) and I was wondering if you still have any time and interest in accepting PRs?

If so, there is a crate implementing the mersenne twister PRNG , which I can add behind a feature flag

@MarcusRainbow
Copy link
Owner Author

MarcusRainbow commented May 11, 2020 via email

@petr-tik
Copy link

I still think there is a real future in using Rust for financial maths. I'm
just waiting for the rest of the world to cotton on to this idea

Hear hear! I guess the hardest problem to solve is acknowledging the moat of C++ and integrating rust with existing codebases as seamlessly as possible. Have you had any success or problems with that?

I agree it would be very good to use Mersenne Twister for the pseudo-random numbers.

If you are happy to look at my PR do you want that behind a feature flag or do you prefer Mersenne Twister replaces rand by default?

@petr-tik
Copy link

I have been looking at your library, while learning about derivatives pricing and I have a question.

In your options pricing model you use the widespread Black-Scholes model with a normal distribution. I have read and heard about different flavours of Black-Scholes using other probability distributions eg. fat-tailed.

https://github.com/MarcusRainbow/QuantMath/blob/master/src/math/optionpricing.rs

Is there any scope/use for adding/trying other pdf for this?

@MarcusRainbow
Copy link
Owner Author

MarcusRainbow commented May 26, 2020 via email

@MarcusRainbow
Copy link
Owner Author

MarcusRainbow commented May 26, 2020 via email

@petr-tik
Copy link

I started poking at it - haven't got a PR yet, but have experienced problems building with the current version of rustc as well as failing tests.

Judging from previous commits you must run CI locally, so I guess flaky tests are ok?

@MarcusRainbow
Copy link
Owner Author

MarcusRainbow commented May 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants