From 7dd3c963f0e6107ca9ee7a0a60e6f6719ddf4ae0 Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 14:29:31 -0300 Subject: [PATCH 1/8] test adding golang variables Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index a20682cbc1..d1881712c6 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -362,6 +362,10 @@ jobs: integration-windows: name: integration (windows) + env: + GOPATH: 'd:\go\path' + GOCACHE: 'd:\go\cache' + GOMODCACHE: 'd:\go\modcache' runs-on: windows-2022 needs: images-windows timeout-minutes: 45 @@ -379,6 +383,7 @@ jobs: uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: 'go.mod' + cache: true - name: Load cached deps uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2 with: @@ -413,6 +418,11 @@ jobs: runs-on: windows-2022 timeout-minutes: 45 + env: + GOPATH: 'd:\go\path' + GOCACHE: 'd:\go\cache' + GOMODCACHE: 'd:\go\modcache' + permissions: contents: read @@ -423,6 +433,7 @@ jobs: uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: 'go.mod' + cache: true - name: Setup dep cache uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2 with: @@ -437,6 +448,11 @@ jobs: needs: cache-deps-windows timeout-minutes: 45 + env: + GOPATH: 'd:\go\path' + GOCACHE: 'd:\go\cache' + GOMODCACHE: 'd:\go\modcache' + permissions: contents: read @@ -450,6 +466,7 @@ jobs: uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: 'go.mod' + cache: true - name: Load cached deps uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2 with: @@ -480,6 +497,11 @@ jobs: needs: cache-deps-windows timeout-minutes: 45 + env: + GOPATH: 'd:\go\path' + GOCACHE: 'd:\go\cache' + GOMODCACHE: 'd:\go\modcache' + permissions: contents: read @@ -493,6 +515,7 @@ jobs: uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: 'go.mod' + cache: true - name: Load cached deps uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2 with: @@ -514,6 +537,11 @@ jobs: needs: cache-deps-windows timeout-minutes: 45 + env: + GOPATH: 'd:\go\path' + GOCACHE: 'd:\go\cache' + GOMODCACHE: 'd:\go\modcache' + permissions: contents: read @@ -527,6 +555,7 @@ jobs: uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: 'go.mod' + cache: true - name: Load cached deps uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2 with: From 89654bed4e17f42a5d29312e2517a18ed03950d2 Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:14:08 -0300 Subject: [PATCH 2/8] using global path Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index d1881712c6..0081517c4c 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -5,6 +5,8 @@ on: merge_group: types: - checks_requested +env: + WINDOWS_GO_PATH: 'D:\golang\' permissions: contents: read @@ -363,9 +365,9 @@ jobs: integration-windows: name: integration (windows) env: - GOPATH: 'd:\go\path' - GOCACHE: 'd:\go\cache' - GOMODCACHE: 'd:\go\modcache' + GOPATH: ${{WINDOWS_GO_PATH}}\go + GOCACHE: ${{WINDOWS_GO_PATH}}\cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache runs-on: windows-2022 needs: images-windows timeout-minutes: 45 @@ -417,11 +419,10 @@ jobs: name: cache-deps (windows) runs-on: windows-2022 timeout-minutes: 45 - env: - GOPATH: 'd:\go\path' - GOCACHE: 'd:\go\cache' - GOMODCACHE: 'd:\go\modcache' + GOPATH: ${{WINDOWS_GO_PATH}}\go + GOCACHE: ${{WINDOWS_GO_PATH}}\cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache permissions: contents: read @@ -449,9 +450,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: 'd:\go\path' - GOCACHE: 'd:\go\cache' - GOMODCACHE: 'd:\go\modcache' + GOPATH: ${{WINDOWS_GO_PATH}}\go + GOCACHE: ${{WINDOWS_GO_PATH}}\cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache permissions: contents: read @@ -498,9 +499,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: 'd:\go\path' - GOCACHE: 'd:\go\cache' - GOMODCACHE: 'd:\go\modcache' + GOPATH: ${{WINDOWS_GO_PATH}}\go + GOCACHE: ${{WINDOWS_GO_PATH}}\cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache permissions: contents: read @@ -538,9 +539,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: 'd:\go\path' - GOCACHE: 'd:\go\cache' - GOMODCACHE: 'd:\go\modcache' + GOPATH: ${{WINDOWS_GO_PATH}}\go + GOCACHE: ${{WINDOWS_GO_PATH}}\cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache permissions: contents: read From 5a524400b81f3e4bb1c4295b87cbf1211bca116c Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:15:46 -0300 Subject: [PATCH 3/8] resolve typo Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index 0081517c4c..0fa20f0e10 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -365,9 +365,9 @@ jobs: integration-windows: name: integration (windows) env: - GOPATH: ${{WINDOWS_GO_PATH}}\go - GOCACHE: ${{WINDOWS_GO_PATH}}\cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache + GOPATH: ${{WINDOWS_GO_PATH}}go + GOCACHE: ${{WINDOWS_GO_PATH}}cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache runs-on: windows-2022 needs: images-windows timeout-minutes: 45 @@ -420,9 +420,9 @@ jobs: runs-on: windows-2022 timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}\go - GOCACHE: ${{WINDOWS_GO_PATH}}\cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache + GOPATH: ${{WINDOWS_GO_PATH}}go + GOCACHE: ${{WINDOWS_GO_PATH}}cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache permissions: contents: read @@ -450,9 +450,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}\go - GOCACHE: ${{WINDOWS_GO_PATH}}\cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache + GOPATH: ${{WINDOWS_GO_PATH}}go + GOCACHE: ${{WINDOWS_GO_PATH}}cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache permissions: contents: read @@ -499,9 +499,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}\go - GOCACHE: ${{WINDOWS_GO_PATH}}\cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache + GOPATH: ${{WINDOWS_GO_PATH}}go + GOCACHE: ${{WINDOWS_GO_PATH}}cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache permissions: contents: read @@ -539,9 +539,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}\go - GOCACHE: ${{WINDOWS_GO_PATH}}\cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}\modcache + GOPATH: ${{WINDOWS_GO_PATH}}go + GOCACHE: ${{WINDOWS_GO_PATH}}cache + GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache permissions: contents: read From 7f1306ea7a9feb672c662cc2910f698197cd2c0a Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:18:31 -0300 Subject: [PATCH 4/8] resolve typo Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index 0fa20f0e10..b27bfc7e0f 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -365,9 +365,9 @@ jobs: integration-windows: name: integration (windows) env: - GOPATH: ${{WINDOWS_GO_PATH}}go - GOCACHE: ${{WINDOWS_GO_PATH}}cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache + GOPATH: ${{ WINDOWS_GO_PATH }}go + GOCACHE: ${{ WINDOWS_GO_PATH }}cache + GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache runs-on: windows-2022 needs: images-windows timeout-minutes: 45 @@ -420,9 +420,9 @@ jobs: runs-on: windows-2022 timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}go - GOCACHE: ${{WINDOWS_GO_PATH}}cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache + GOPATH: ${{ WINDOWS_GO_PATH }}go + GOCACHE: ${{ WINDOWS_GO_PATH }}cache + GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache permissions: contents: read @@ -450,9 +450,10 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}go - GOCACHE: ${{WINDOWS_GO_PATH}}cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache + GOPATH: ${{ WINDOWS_GO_PATH }}go + GOCACHE: ${{ WINDOWS_GO_PATH }}cache + GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache + permissions: contents: read @@ -499,9 +500,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}go - GOCACHE: ${{WINDOWS_GO_PATH}}cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache + GOPATH: ${{ WINDOWS_GO_PATH }}go + GOCACHE: ${{ WINDOWS_GO_PATH }}cache + GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache permissions: contents: read @@ -539,9 +540,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{WINDOWS_GO_PATH}}go - GOCACHE: ${{WINDOWS_GO_PATH}}cache - GOMODCACHE: ${{WINDOWS_GO_PATH}}modcache + GOPATH: ${{ WINDOWS_GO_PATH }}go + GOCACHE: ${{ WINDOWS_GO_PATH }}cache + GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache permissions: contents: read From 7fe4a5511823690c6254041fc06949a45425c211 Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:23:44 -0300 Subject: [PATCH 5/8] more... Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 39 ++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index b27bfc7e0f..1983228627 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -6,7 +6,9 @@ on: types: - checks_requested env: - WINDOWS_GO_PATH: 'D:\golang\' + WINDOWS_GO_PATH: 'D:\golang\go' + WINDOWS_GO_CACHE: 'D:\golang\cache' + WINDOWS_GO_MODCACHE: 'D:\golang\modcache' permissions: contents: read @@ -364,14 +366,15 @@ jobs: integration-windows: name: integration (windows) - env: - GOPATH: ${{ WINDOWS_GO_PATH }}go - GOCACHE: ${{ WINDOWS_GO_PATH }}cache - GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache runs-on: windows-2022 needs: images-windows timeout-minutes: 45 + env: + GOPATH: ${{ WINDOWS_GO_PATH }} + GOCACHE: ${{ WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + permissions: contents: read @@ -419,10 +422,11 @@ jobs: name: cache-deps (windows) runs-on: windows-2022 timeout-minutes: 45 + env: - GOPATH: ${{ WINDOWS_GO_PATH }}go - GOCACHE: ${{ WINDOWS_GO_PATH }}cache - GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache + GOPATH: ${{ WINDOWS_GO_PATH }} + GOCACHE: ${{ WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -450,10 +454,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }}go - GOCACHE: ${{ WINDOWS_GO_PATH }}cache - GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache - + GOPATH: ${{ WINDOWS_GO_PATH }} + GOCACHE: ${{ WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -500,9 +503,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }}go - GOCACHE: ${{ WINDOWS_GO_PATH }}cache - GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache + GOPATH: ${{ WINDOWS_GO_PATH }} + GOCACHE: ${{ WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -540,9 +543,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }}go - GOCACHE: ${{ WINDOWS_GO_PATH }}cache - GOMODCACHE: ${{ WINDOWS_GO_PATH }}modcache + GOPATH: ${{ WINDOWS_GO_PATH }} + GOCACHE: ${{ WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} permissions: contents: read From 17d9fb1e942b0a48c0aed4ffde29bc935118698d Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:34:13 -0300 Subject: [PATCH 6/8] more... Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index 1983228627..6fb9da1db2 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -371,9 +371,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }} - GOCACHE: ${{ WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + GOPATH: ${{ env.WINDOWS_GO_PATH }} + GOCACHE: ${{ env.WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -424,9 +424,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }} - GOCACHE: ${{ WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + GOPATH: ${{ env.WINDOWS_GO_PATH }} + GOCACHE: ${{ env.WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -454,9 +454,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }} - GOCACHE: ${{ WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + GOPATH: ${{ env.WINDOWS_GO_PATH }} + GOCACHE: ${{ env.WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -503,9 +503,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }} - GOCACHE: ${{ WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + GOPATH: ${{ env.WINDOWS_GO_PATH }} + GOCACHE: ${{ env.WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} permissions: contents: read @@ -543,9 +543,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ WINDOWS_GO_PATH }} - GOCACHE: ${{ WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ WINDOWS_GO_MODCACHE }} + GOPATH: ${{ env.WINDOWS_GO_PATH }} + GOCACHE: ${{ env.WINDOWS_GO_CACHE }} + GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} permissions: contents: read From baea33ed9f570985f8a069a9974bc5f50aec7ad6 Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 16:58:23 -0300 Subject: [PATCH 7/8] more... Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index 6fb9da1db2..38729cb0d3 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -5,10 +5,6 @@ on: merge_group: types: - checks_requested -env: - WINDOWS_GO_PATH: 'D:\golang\go' - WINDOWS_GO_CACHE: 'D:\golang\cache' - WINDOWS_GO_MODCACHE: 'D:\golang\modcache' permissions: contents: read @@ -371,9 +367,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ env.WINDOWS_GO_PATH }} - GOCACHE: ${{ env.WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} + GOPATH: 'D:\golang\go' + GOCACHE: 'D:\golang\cache' + GOMODCACHE: 'D:\golang\modcache' permissions: contents: read @@ -424,9 +420,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ env.WINDOWS_GO_PATH }} - GOCACHE: ${{ env.WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} + GOPATH: 'D:\golang\go' + GOCACHE: 'D:\golang\cache' + GOMODCACHE: 'D:\golang\modcache' permissions: contents: read @@ -454,9 +450,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ env.WINDOWS_GO_PATH }} - GOCACHE: ${{ env.WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} + GOPATH: 'D:\golang\go' + GOCACHE: 'D:\golang\cache' + GOMODCACHE: 'D:\golang\modcache' permissions: contents: read @@ -503,9 +499,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ env.WINDOWS_GO_PATH }} - GOCACHE: ${{ env.WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} + GOPATH: 'D:\golang\go' + GOCACHE: 'D:\golang\cache' + GOMODCACHE: 'D:\golang\modcache' permissions: contents: read From 95e251f451a746e1912555293170c63c88541625 Mon Sep 17 00:00:00 2001 From: Marcos Yacob Date: Wed, 15 May 2024 17:02:03 -0300 Subject: [PATCH 8/8] more... Signed-off-by: Marcos Yacob --- .github/workflows/pr_build.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml index 38729cb0d3..4321198a55 100644 --- a/.github/workflows/pr_build.yaml +++ b/.github/workflows/pr_build.yaml @@ -539,9 +539,9 @@ jobs: timeout-minutes: 45 env: - GOPATH: ${{ env.WINDOWS_GO_PATH }} - GOCACHE: ${{ env.WINDOWS_GO_CACHE }} - GOMODCACHE: ${{ env.WINDOWS_GO_MODCACHE }} + GOPATH: 'D:\golang\go' + GOCACHE: 'D:\golang\cache' + GOMODCACHE: 'D:\golang\modcache' permissions: contents: read