-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/required and nullable difference #150
Open
domenikjones
wants to merge
9
commits into
Manweill:main
Choose a base branch
from
domenikjones:bugfix/required-and-nullable-difference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix/required and nullable difference #150
domenikjones
wants to merge
9
commits into
Manweill:main
from
domenikjones:bugfix/required-and-nullable-difference
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manweill
reviewed
Sep 16, 2021
|
||
text = disableLint() + text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove disableLint
You should refer to the code itself to coding style, in prettier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We have found a problem concerning nullable fields which lead into more problems, if we are using
required
,readOnly
andnullabel
in combination.To keep the possibility as before,
strictRequiredChecks
has been added.undefined
valuesnull
valuesWe have implemented some changes:
nullable
andreadOnly
A field is required when:
readOnly
is false and property isrequired
is true orstrictRequiredChecks
is falseA field is nullable when:
nullable
is true orstrictNullChecks
is falseThese changes might break implementations of other developers, since
strictNullCheck
has been moved to thenullable
evaluation insteadrequired
akaundefined
.Minor changes and fixes:
Please let me know this poses a problem. Happy coding!