Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide balanced installation/contribution instructions #21

Open
hasufell opened this issue May 16, 2024 · 4 comments
Open

Provide balanced installation/contribution instructions #21

hasufell opened this issue May 16, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers UX issues that affect usability of cabal-audit

Comments

@hasufell
Copy link

Both the installation section and the contribution section tell me to use nix as the first option. In the worst case, this will make an uninformed newcomer install nix and go down a rabbit hole of tooling nightmares (YMMV).

I suggest to be a bit more balanced. Cabal and Stack are by far the most popular options to build haskell projects: https://taylor.fausak.me/2022/11/18/haskell-survey-results/#s3q0

I don't see a stack.yaml in this repo either.

@MangoIV
Copy link
Owner

MangoIV commented May 16, 2024

Hi! That's a great idea. Providing contribution instructions using cabal should be trivial, it should already “just work”. I will do that.

I probably won’t maintain a stack.yaml though, I never personally use that tool and it is kinda subsumed by what nix does.

@MangoIV MangoIV added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 16, 2024
MangoIV added a commit that referenced this issue May 16, 2024
MangoIV added a commit that referenced this issue May 16, 2024
@MangoIV MangoIV added the UX issues that affect usability of cabal-audit label May 16, 2024
MangoIV added a commit that referenced this issue May 31, 2024
MangoIV added a commit that referenced this issue May 31, 2024
[chore] repair adjust nix dev env
@telser
Copy link

telser commented Jun 6, 2024

This would be great. For example, trying just now:

git clone [email protected]:MangoIV/cabal-audit.git 
cd cabal-audit
cabal update
cabal install
cabal run cabal-audit

Apparently does not work, resulting in the following error:

cabal-audit failed:
Listing the advisories in directory /tmp/cabal-audit-f2a93cceff80dacf failed with: 
[AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n",AdvisoryError [MatchMessage {matchAnn = Nothing, matchPath = [], matchMessage = "missing mandatory key: advisory.date"}] "missing mandatory key: advisory.date in <top-level>\n"]

@MangoIV
Copy link
Owner

MangoIV commented Jun 6, 2024

can you come around? I don’t think the reason has anything to do with the installation, it’s an upstream bug in the security advisories tooling. The PR I have open there will fix it.

@MangoIV
Copy link
Owner

MangoIV commented Jun 6, 2024

The issue is how git outputs dates and how the security-advisories tooling parsers them.

@MangoIV MangoIV self-assigned this Jun 8, 2024
MangoIV added a commit that referenced this issue Jun 15, 2024
[chore] documentation update for #21, repair nix dev env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers UX issues that affect usability of cabal-audit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants