Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bastions breaking with RSR enabled. #548

Open
Ravaner1337 opened this issue Nov 29, 2024 · 5 comments
Open

[BUG] Bastions breaking with RSR enabled. #548

Ravaner1337 opened this issue Nov 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Ravaner1337
Copy link

Description
Steps to Reproduce

  1. Go to the bastion tab in the DND 5E System.
  2. Click on Bastions and issue any order such as Craft,Trade,Recruit.
  3. Expected Result : A window should pop up about your order and allowing you to confirm.
  4. No window pops up and no bastion order is issued. This is fixed when disabling Ready Set Roll.

Versions

  • Module: Ready Set Roll Version 3.4.2
  • dnd5e: Version 4.1.1
  • Foundry: Version 12 build 331.

Other Modules
Seems to be only affected by roll modules such as RSR.

@Ravaner1337 Ravaner1337 added the bug Something isn't working label Nov 29, 2024
@MangoFVTT
Copy link
Owner

@Ravaner1337 I do not have any access to the DMG module yet and as such no easy way to test Bastion orders. If you can export one of the facility items that is breaking for you so I can import it accordingly, that would make it possible for me to fix this ticket

@Ravaner1337
Copy link
Author

Ravaner1337 commented Dec 8, 2024

This is testable without the DMG if you want to test the other features other than "harvest", just create a homebrew facility in the item tab and assign it a order and you face the same result.

@Ravaner1337
Copy link
Author

Here is an atttempt of remaking the greenhouse from 5E, it's suppose to grant you a health potion once the turn ends but does nothing.
fvtt-Item-greenhouse-VSGU3zuW46LUrnK0.json

@Ravaner1337
Copy link
Author

@MangoFVTT Is any other examples needed?

@MangoFVTT
Copy link
Owner

@Ravaner1337 No examples need that should be sufficient 👍 I'm currently abroad until early January over the Christmas holidays, so I don't have access to my dev environment (hence the delay). I'll look into the fix for this once I return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants