Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compatibility with Roll Groups Issue #385

Closed
DrWiFi opened this issue Feb 25, 2024 · 4 comments
Closed

[BUG] Compatibility with Roll Groups Issue #385

DrWiFi opened this issue Feb 25, 2024 · 4 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@DrWiFi
Copy link

DrWiFi commented Feb 25, 2024

Description
With Ready Set Roll and Roll Groups enabled, rolling damage from the Roll Group interface generates errors.
Issue only happens when both Roll Groups and Ready Set Roll are installed.
Screenshot 2024-02-25 at 2 43 30 PM

Steps to Reproduce

  1. Configure Cantrip and Weapon with Roll Groups
  2. Cast Cantrip
  3. Click either Weapon Attack or Combined Damage
  4. Roll Damage
  5. Dice will roll, but no chat output, plus error in console
Screenshot 2024-02-25 at 3 06 30 PM

Versions

  • Module: [3.0.10]
  • dnd5e: [3.0.3]
  • Foundry: [11.315]

Other Modules
Roll Groups

Thanks

@DrWiFi DrWiFi added the bug Something isn't working label Feb 25, 2024
@MangoFVTT
Copy link
Owner

MangoFVTT commented Feb 26, 2024

@DrWiFi Compatibility for Roll Groups is already being tracked in this ticket: #331.

However as per my current tests, while Roll Groups and RSR does lead to some strange behaviour for cards, I see no errors coming up as you are experiencing. An item with Roll Groups set up will correctly display damage buttons for those roll groups, and roll them into separate cards as expected.

image

Are you certain you are not using any other modules? The popup window I see in your screenshot as far as I know does not come from Roll Groups and does not come from RSR either, for example? I don't personally use Roll Groups for reference, so if this is incorrect I would appreciate more clarification on the exact setup of your items with Roll Groups and RSR to see if I can reproduce the issue.

@MangoFVTT MangoFVTT added the duplicate This issue or pull request already exists label Feb 26, 2024
@krbz999
Copy link

krbz999 commented Feb 27, 2024

The additional window is from Roll Groups' blade cantrip functionality. This is something that can be set up in a valid cantrip such as Green-Flame Blade.

@DrWiFi
Copy link
Author

DrWiFi commented Feb 27, 2024

Yes, Zhell is correct.
The Cantrip I setup for this was Booming Blade as a blade cantrip.
Sorry for that missing information.

@MangoFVTT
Copy link
Owner

In that case, I'm closing this as a duplicate of #331 and use that ticket for tracking.

@MangoFVTT MangoFVTT closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants