[BUG] Disabling attack roll in quick rolls causes default item card to be rolled

[maxobremer]

Description
If an item with an attack roll has its attack roll disabled, it will roll the default foundry item card with non of the RSR additions/improvements

Steps to Reproduce

1. Have an item that has an attack roll (and possibly a damage roll?)
2. Go to quick roll and disable the attack roll option
3. Roll the item
4. See result
   
   (also works if i swap the normal and alt rolls settings around btw)

Versions

• Module: [3.0.7]
• dnd5e: [3.0.2]
• Foundry: [11.315]

Other Modules
A list of any other installed modules that might be related to the issue.
-None

[maxobremer]

also to not make a new issue for a single question, is it feasible to have the damage types split like it was in the pre dnd5e v3 version of this module? would be nice for situations like ice knife and the Giant Spider's Bite as those have some conditional damage

[MangoFVTT]

@maxobremer I haven't been able to reproduce this issue on my end. Disabling the Attack in the quick roll config seems to work as expected for multiple items (see image below). Could you check if this problem is happening for you on all items? If not, try recreating the item that is giving you the problem.

also to not make a new issue for a single question, is it feasible to have the damage types split like it was in the pre dnd5e v3 version of this module? would be nice for situations like ice knife and the Giant Spider's Bite as those have some conditional damage

Damage types are split inside the tooltip now, since RSR uses the default dnd5e system damage output to split up damages appropriately. You can access the individual damage types by opening the tooltip:

[maxobremer]

Made a new actor and a new weapon and got the same result:

Just in case, here is a list of my settings:

after messing around a bit I think it has to do with the Always Roll Multiple Dice settings. With that unchecked the issue doesn't seem to be there but with it checked it is.

Damage types are split inside the tooltip now, since RSR uses the default dnd5e system damage output to split up damages appropriately. You can access the individual damage types by opening the tooltip:

Maybe I should rephrase, is it feasible to have them be separate buttons to roll and show up split outside the tooltip? Else you have most situations where the players need to apply just the total sum, but only a few where they have to open up the tooltip to then apply the individual damages. Also the damages in the tooltip still gets bundled together if they have the same type, even when they might be meant for different things. For example a Giant Slayer Longsword (and to note the other formula field doesn't really work well since you can apply context or a damage type to that properly. You can add [cold] or something for damage, but if you apply the damage, which you have to do by right clicking the new damage roll, then it doesnt take for example resistance into effect)

Or whatever else:

[MangoFVTT]

Your primary bug has been resolved and will be in the next release.

Maybe I should rephrase, is it feasible to have them be separate buttons to roll and show up split outside the tooltip? Else you have most situations where the players need to apply just the total sum, but only a few where they have to open up the tooltip to then apply the individual damages.

No unfortunately not that feasible. Since RSR 3.0 is more closely tied to system behaviour now (to facilitate maintenance and make it work better with other popular modules) it relies on how the system rolls and displays damage, and the system does that as a whole package. You CAN use alternate rolls to have two separate batches of damage as two separate cards, and use the roll config to omit certain damage fields in the base roll while showing them in the alt roll, but that's the extent of the functionality RSR offers. That being said, compatibility with Roll Groups (which does exactly what you are asking for) is being worked on and can be tracked in #331.

Also the damages in the tooltip still gets bundled together if they have the same type, even when they might be meant for different things.

This is a dnd5e system issue (it bundles same damage types together internally, nothing RSR can do about it), and should be brought up on their github. It bothers me as well, and I wouldn't be surprised if there were already issues requesting it be changed.