You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[before starting with this, ensure that Pinterest's urlData is not commented out.]
Issue is easies to repro on Pinterest:
Try to move horizontally to from a CU where the best matching CU for the movement is outside the viewport, but there are other matching CUs within the viewport. Nothing happens.
Some notes for resolution:
Either the best match CU in the viewport should get selected
or we should scroll to the be best matching CU that is outside the viewport
or maybe, the current behavior (of trying to scroll the page should instead be maintained, but if there is no scroll movement (in that direction) possible on the page, then either 1) or 2) should be done.
[before starting with this, ensure that Pinterest's urlData is not commented out.]
Issue is easies to repro on Pinterest:
Try to move horizontally to from a CU where the best matching CU for the movement is outside the viewport, but there are other matching CUs within the viewport. Nothing happens.
Some notes for resolution:
isCUFullyInViewport()
andisAnyPartOfCUinViewport()
to be updated to factor in the horizontal dimension as well #199 first (and consider it's implications to the problem as well)The text was updated successfully, but these errors were encountered: