Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with directional CU movement -- easily repro-able in Pinterest #210

Open
ghost opened this issue Oct 23, 2013 · 0 comments
Open

issue with directional CU movement -- easily repro-able in Pinterest #210

ghost opened this issue Oct 23, 2013 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 23, 2013

[before starting with this, ensure that Pinterest's urlData is not commented out.]

Issue is easies to repro on Pinterest:

Try to move horizontally to from a CU where the best matching CU for the movement is outside the viewport, but there are other matching CUs within the viewport. Nothing happens.

Some notes for resolution:

  1. Either the best match CU in the viewport should get selected
  2. or we should scroll to the be best matching CU that is outside the viewport
  3. or maybe, the current behavior (of trying to scroll the page should instead be maintained, but if there is no scroll movement (in that direction) possible on the page, then either 1) or 2) should be done.
  4. Also, close modCUs_mgr: isCUFullyInViewport() and isAnyPartOfCUinViewport() to be updated to factor in the horizontal dimension as well #199 first (and consider it's implications to the problem as well)
@ghost ghost self-assigned this Oct 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants