Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incl. LinearOperatorCollection v2 #200

Closed
wants to merge 1 commit into from

Conversation

JakobAsslaender
Copy link
Member

@tknopp: can you merge and release this change? I still don't understand, how to release these sub-packages without breaking everything.

Another quick question: the compat helper doesn't work with sub-projects, does it? It would be nice to get that working to avoid the manual labor of updating packages.

@JakobAsslaender
Copy link
Member Author

It seems that the CI failures are unrelated to this compat update, they are the same failures as the master branch. I tested the subpackage locally and it passed all tests.

@tknopp
Copy link
Member

tknopp commented Aug 13, 2024

@nHackel: could you comment on this? I recall that we are currently in a bad state and it requires merging the gpu branch?

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

The GPU branch is ready to be merged and increases the compat for LinearOperatorCollection to 2.0

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

I think the bad state was partially that in the current master we are not yet using the correct keyword for the normal operator. I don't recall all the details, but things should be fixed in the gpu branch

@tknopp tknopp closed this Aug 13, 2024
@tknopp
Copy link
Member

tknopp commented Aug 13, 2024

ok, merged. I would then directly release 0.9, right?

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

Hmm it's probably for the best. MRIOperators definitely had breaking changes and increased to 0.3.

From an interface perspective I think MRIReco only had bug fixes and the new arrayType keyword, but we increased the requirements for MRIOperators to the new version...which I think would count as a breaking change since we increased our lower compat bound

@tknopp
Copy link
Member

tknopp commented Aug 13, 2024

MRIBase/Operators is already triggered...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants