Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-fetch because fetch has been supported natively #409

Closed
Keith-CY opened this issue Jul 9, 2024 · 2 comments
Closed

Remove node-fetch because fetch has been supported natively #409

Keith-CY opened this issue Jul 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 9, 2024

This issue comes from Magickbase/neuron#406

Fetch has been supported since Node.js@18 natively while Neuron uses Electron@30(https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/package.json#L96), delivered with Node.js@20, so the external module node-fetch can be removed.

Ref:

@Keith-CY Keith-CY added this to Neuron Jul 9, 2024
@Danie0918 Danie0918 moved this to 🆕 New in Neuron Jul 9, 2024
@Danie0918 Danie0918 added the enhancement New feature or request label Jul 9, 2024
@Danie0918 Danie0918 moved this from 🆕 New to 🏗 In Progress in Neuron Jul 15, 2024
@Danie0918 Danie0918 moved this from 🏗 In Progress to 🎨 Designing in Neuron Jul 16, 2024
@Danie0918 Danie0918 removed their assignment Jul 19, 2024
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron Jul 22, 2024
@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 26, 2024

My bad, the lib to remove is https://github.com/nodejs/undici, a temp lib before native node fetch is supported.

@devchenyan
Copy link

pr: nervosnetwork/neuron#3213

@Keith-CY Keith-CY moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jul 26, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 🚩Pre Release in Neuron Jul 26, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants