Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC 1155 Token Collection List filtering data is abnormal. #1086

Open
FrederLu opened this issue Oct 14, 2022 · 6 comments
Open

ERC 1155 Token Collection List filtering data is abnormal. #1086

FrederLu opened this issue Oct 14, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@FrederLu
Copy link

FrederLu commented Oct 14, 2022

image

image

https://godwoken-explorer-6z22m4y4m-magickbase.vercel.app/multi-token-collections?page_size=50&name=Events&before=g3QAAAABZAACaWRiAADPjQ%3D%3D

{"query":"\n query ($limit: Int, $name: String, $before: String, $after: String) {\n erc1155_udts(input: { limit: $limit, fuzzy_name: $name, before: $before, after: $after }) {\n entries {\n id\n name\n symbol\n icon\n account {\n eth_address\n }\n holders_count\n minted_count\n }\n metadata {\n total_count\n after\n before\n }\n }\n }\n","variables":{"before":null,"after":"g3QAAAABZAACaWRiAAC_hQ==","name":"Events%","limit":50}}

image

https://godwoken-explorer-6z22m4y4m-magickbase.vercel.app/multi-token-collections?page_size=50&name=Events&after=g3QAAAABZAACaWRiAAC5jA%3D%3D

{"query":"\n query ($limit: Int, $name: String, $before: String, $after: String) {\n erc1155_udts(input: { limit: $limit, fuzzy_name: $name, before: $before, after: $after }) {\n entries {\n id\n name\n symbol\n icon\n account {\n eth_address\n }\n holders_count\n minted_count\n }\n metadata {\n total_count\n after\n before\n }\n }\n }\n","variables":{"before":"g3QAAAABZAACaWRiAADPjQ==","after":null,"name":"Events%","limit":50}}

Now, 4 pieces of data are displayed in pagination, which can actually be displayed on one page.

@FrederLu FrederLu added the bug Something isn't working label Oct 14, 2022
@Keith-CY
Copy link
Member

What's the filter key, I've tried with EVENT and got 4 records with displaying 4 kinds in total

https://godwoken-explorer-ui-git-enable-erc-1155-magickbase.vercel.app/multi-token-collections?name=EVENT

The issue in the screenshot needs help from @Naupio, 4 records with limit=50 are split into 2 pages.

And I've two pieces of advice for this issue.

  1. the URL showing 3 records with 4 kinds in total could be appended so I can debug it
  2. metadata in the network panel could be included so we can make real data from the API clear

@Keith-CY Keith-CY assigned Naupio and unassigned Keith-CY Oct 17, 2022
@Keith-CY Keith-CY added this to the 2022/10/12 - 2022/10/19 milestone Oct 17, 2022
@FrederLu
Copy link
Author

Ok, some data has been updated and uploaded.#1086 (comment)

@Keith-CY Keith-CY moved this from Todo to QA in Nervos Wallet/Explorer Nov 2, 2022
@FrederLu
Copy link
Author

FrederLu commented Nov 2, 2022

https://v1.testnet.gwscan.com/multi-token-collections?before=g3QAAAABZAACaWRiAABZLA%3D%3D&name=Events

{"query":"\n query ($limit: Int, $name: String, $before: String, $after: String) {\n erc1155_udts(input: { limit: $limit, fuzzy_name: $name, before: $before, after: $after }) {\n entries {\n id\n name\n symbol\n icon\n account {\n eth_address\n }\n holders_count\n minted_count\n token_type_count\n }\n metadata {\n total_count\n after\n before\n }\n }\n }\n","variables":{"before":"g3QAAAABZAACaWRiAABZLA==","after":null,"name":"Events%","limit":30}}

Image

@Keith-CY
The problem still exists on testnet.
In the Multi-token Collection, after turning one page from the home page and then returning to the home page to filter Events, 4 pieces of data are displayed, but the page has no data.

@FrederLu FrederLu moved this from QA to Todo in Nervos Wallet/Explorer Nov 2, 2022
@Keith-CY Keith-CY moved this from Todo to In Progress in Nervos Wallet/Explorer Nov 7, 2022
@Naupio
Copy link
Contributor

Naupio commented Nov 9, 2022

decode cursor result

Paginator.Cursor.decode "g3QAAAABZAACaWRiAABZLA=="
%{id: 22828}

@Naupio
Copy link
Contributor

Naupio commented Nov 9, 2022

In Testnet Stg ENV, the records with name like 'Events%' of erc1155 is
image

and the before cursor is %{id: 22828}, seems no data of before curosr "g3QAAAABZAACaWRiAABZLA==" (%{id: 22828})

@FrederLu
Copy link
Author

FrederLu commented Nov 9, 2022

@Naupio
Now filtering data on the first page of Multi-token Collection and NFT Collections on stg is normal, but there is still a problem with filtering on other pages.
Filter at last page:
Image
Image

Filter on non-first and non-last pages,the same problem applies to the Multi-token Collection page. The screenshot below uses the NFT Collections page.
Image
Image
Image
Image

On the Bridged Token List and Layer 2 Native Token List pages, there are similar problems through the same operation (filtering on the non-first page).
Image
Image
Image

Image
Image
Image

Other pages:
Image
Image
Image

@Keith-CY Keith-CY moved this from In Progress to Todo in Nervos Wallet/Explorer Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants