Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Magic Mirror Server and Client mode documentation #186
base: master
Are you sure you want to change the base?
Update Magic Mirror Server and Client mode documentation #186
Changes from 15 commits
70acd0c
956cc9e
f158683
68522f3
457bdf5
d6cd8c7
2502639
2445414
51810c9
0b20703
14fec29
1d92044
433214a
ab6f81c
0bc1e54
1429733
7e8f28f
154a843
a78bd1f
2ce3c94
4e451f8
43103c3
942936f
6b6eb2d
87ff347
f642eb1
82004ba
61f70b7
89b6259
7f29d9b
98b72b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rejas last time you lintered the lines to a max. length, will you do this here before/after merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after merge I will lint again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rejas don't know anything about this
mm.sh
stuff, totally irrelevant when using docker, so is this a standard setup or how should we document it here?Found in
mm.sh
this line# This file is still here to keep PM2 working on older installations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
mm.sh
file is removed ondevelop
soinstallers/mm.sh
will not exist anymore with next release. This file will be part of sam's script repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please remove the stuff about mm.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm server
this will not work, must benpm run server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its running for me with
npm server
changed it tonpm run server
and didn't see any difference. but i'll admit i don't fully understand how this works, just documenting what i had to do to get it working :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also say, that
npm server
does not work for me (or in general as far as i know). Only a few scripts work out of the box, likestart
andtest
Maybe you got some shortcuts somewhere, but please update here to use "start"