Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make num_extra_commenters visible in dark mode #1701

Merged
merged 2 commits into from
Oct 16, 2023
Merged

make num_extra_commenters visible in dark mode #1701

merged 2 commits into from
Oct 16, 2023

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented Sep 30, 2023

No description provided.

@Bomme Bomme requested a review from ffont September 30, 2023 21:50
ffont
ffont approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@ffont ffont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I finally fixed it in a different way, by explicitly adding the class "text-black" and not "inheriting" the colour from p.

@ffont ffont merged commit cc197ad into master Oct 16, 2023
1 check passed
@ffont ffont deleted the display_thread_dark_mode branch October 16, 2023 13:16
@ffont ffont restored the display_thread_dark_mode branch October 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffont ffont ffont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bomme @ffont