Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DLLAttach stuff #225

Open
SaintWish opened this issue Oct 24, 2023 · 1 comment
Open

Refactor DLLAttach stuff #225

SaintWish opened this issue Oct 24, 2023 · 1 comment
Labels
bug 🐛 Something isn't working enhancement 🔧 New feature or request game Related to the game's code. med priority Issue that should be addressed as time allows.

Comments

@SaintWish
Copy link
Contributor

Need to refactor the MSGlobals::DLLAttach, BOOL WINAPI DllMain, MSCLGlobals::DLLDetach, andMSGlobals::DLLDetach.

Probably get rid of BOOL WINAPI DllMain altoegther once we either switch to using the goldsrc filesystem for everything or figure why using pfnGetGameDirectory crashes.
@SaintWish SaintWish added bug 🐛 Something isn't working enhancement 🔧 New feature or request med priority Issue that should be addressed as time allows. game Related to the game's code. labels Oct 24, 2023
@SaintWish SaintWish mentioned this issue Sep 23, 2024
Open
@a1batross
Copy link
Contributor

In #261 I moved DLLAttach and DLLDetach calls to the init and shutdown callbacks of client.dll on non-Win32 platform.

The first thing engine calls after loading client.dll is Initialize and the last thing is HUD_Shutdown. I don't know why exactly you need this, but it seems to be running fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working enhancement 🔧 New feature or request game Related to the game's code. med priority Issue that should be addressed as time allows.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a1batross @SaintWish