moneymong-520 feat: 회원가입 플로우 개선 작업 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhg3410
requested changes
Dec 16, 2024
Comment on lines
300
to
316
| Text( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .noRippleClickable { | ||
| viewModel.eventEmit( | ||
| SignUpSideEffect.CreateUniversityApi( | ||
| state.selectedUniv, | ||
| state.gradeInfor | ||
| ) | ||
| ) | ||
| navigateToAgency() | ||
| }, | ||
| textAlign = TextAlign.Center, | ||
| text = "총무에게 초대받았어요", | ||
| style = Body3, | ||
| color = Blue04 | ||
| ) |
There was a problem hiding this comment.
은서님 "총무에게 초대받았어요" 버튼 클릭한 뒤 소속 검색화면으로 가면 대학 정보가 없다는 에러가 뜹니다!
로그를 찍어보니 viewModel 에 있는 함수가 실행되기 전에 navigateToAgency() 로 화면이 이동되면서 대학 정보를 만들지 않는 것으로 추측돼요!
Comment on lines
180
to
190
|
|
||
| Box( | ||
| Column( | ||
| modifier = Modifier | ||
| .padding(top = 40.dp) | ||
| .padding(top = 28.dp, end = 28.dp) | ||
| .fillMaxWidth() | ||
| ) { | ||
| if (!state.isSelected) { | ||
| SearchUnivView( | ||
| isFilled = state.isFilled, | ||
| isFilledChanged = { isFilled -> viewModel.isFilledChanged(isFilled) }, | ||
| isListVisible = state.isListVisible, | ||
| isListVisibleChanged = { isListVisible -> | ||
| viewModel.isListVisibleChanged( | ||
| isListVisible | ||
| ) | ||
| }, | ||
| isItemSelectedChanged = { isItemSelected -> | ||
| viewModel.isItemSelectedChanged( | ||
| isItemSelected | ||
| ) | ||
| }, | ||
| isItemSelected = state.isItemSelected, | ||
| textValue = state.textValue, | ||
| universityResponse = state.universityResponse, | ||
| onClick = { | ||
| viewModel.isSelectedChanged(true) | ||
| viewModel.selectedUnivChanged(it) | ||
| }, | ||
| onChange = { viewModel.textValueChanged(it) }, | ||
| onSearchIconClicked = { | ||
| viewModel.eventEmit(SignUpSideEffect.UniversitiesApi(it)) | ||
| }, | ||
| value = state.textValue, | ||
| isButtonVisibleChanged = { isButtonVisible -> viewModel.isButtonVisibleChanged(isButtonVisible)} | ||
| Text( | ||
| text = "소속 유형", | ||
| style = Body2, | ||
| color = Color.Black | ||
| ) |
There was a problem hiding this comment.
여기 padding 이 vertical 에만 들어가야 합니다!
Comment on lines
174
to
179
| SignUpTitleView( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(top = 8.dp), | ||
| subTitleState = state.subTitleState | ||
| .height(89.dp) | ||
| .padding(top = 12.dp, bottom = 12.dp), | ||
| ) |
There was a problem hiding this comment.
height 고정적으로 부여하면 디바이스 글자 크기에 따라 화면에 잘릴 수 있어요!
Comment on lines
118
to
125
| content = { | ||
| SignUpContent( | ||
| modifier = Modifier.padding(innerPadding), | ||
| navigateToSignComplete = navigateToSignComplete, | ||
| navigateToLedger = navigateToLedger, | ||
| navigateToSignUpUniversity = navigateToSignUpUniversity, | ||
| navigateToAgency = navigateToAgency, | ||
| viewModel = viewModel, | ||
| state = state | ||
| ) |
There was a problem hiding this comment.
TopBar 영역과 content 영역이 구분되지 않고 있어요!
content 람다에 제공되는 파라미터인 padding 값을 SignUpContent 의 Modifier에 제공해야 TopBar 영역만큼 padding 이 부여돼요!
content = { paddingValues ->
SignUpContent(
modifier = Modifier.padding(paddingValues),
navigateToLedger = navigateToLedger,
navigateToSignUpUniversity = navigateToSignUpUniversity,
navigateToAgency = navigateToAgency,
viewModel = viewModel,
state = state
)
}
Comment on lines
45
to
55
| MDSButton( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| modifier = Modifier.fillMaxWidth() | ||
| .height(56.dp), | ||
| onClick = { | ||
| onCreateUniversity() | ||
| if(agencyType == AgencyType.GENERAL || pageType == 2) onCreateUniversity() else if (agencyType != AgencyType.GENERAL && pageType == 1) navigateToSignUpUniversity(agencyName, agencyType) | ||
| }, | ||
| text = "가입하기", | ||
| text = if(agencyType == AgencyType.GENERAL || pageType == 2) "등록하기" else "다음으로", | ||
| type = MDSButtonType.PRIMARY, | ||
| size = MDSButtonSize.LARGE, | ||
| enabled = isEnabled | ||
| ) |
There was a problem hiding this comment.
이미 MDSButton 의 size 파라미터로 디자인 시스템에서 지정한 vertical padding 이 지정되어 있어요! 그래서 Modifer 에 있는 height 값은 의미가 없어보여요!
Comment on lines
261
to
263
| SignUpButtonView( | ||
| modifier = Modifier.fillMaxWidth() | ||
| .padding(horizontal = if (state.editTextFocused) 0.dp else MMHorizontalSpacing), |
There was a problem hiding this comment.
editTextFocused 되었을 때 corner radius 값도 수정되어야 해요!
MDSButton의 파라미터에 radius 값을 추가하는 방식으로 해도 좋을 것 같아요!
현재는 아래처럼 보여요!
Comment on lines
109
to
117
| content = { | ||
| SignUpUniversityContent( | ||
| navigateToLedger = navigateToLedger, | ||
| agencyName = agencyName, | ||
| agencyType = agencyType, | ||
| viewModel = viewModel, | ||
| state = state | ||
| ) | ||
| } |
There was a problem hiding this comment.
"어디 학교 교내 동아리인가요?" Text 가 TopBar 에 가려져서 보이지 않아요!
Scaffold 에서 제공하는 padding 값을 제공하지 않아서 겹치는 것으로 확인됩니다!!
Suggested change
| content = { | |
| SignUpUniversityContent( | |
| navigateToLedger = navigateToLedger, | |
| agencyName = agencyName, | |
| agencyType = agencyType, | |
| viewModel = viewModel, | |
| state = state | |
| ) | |
| } | |
| content = { paddingValues -> | |
| SignUpUniversityContent( | |
| modifier = Modifier.padding(paddingValues), | |
| navigateToLedger = navigateToLedger, | |
| agencyName = agencyName, | |
| agencyType = agencyType, | |
| viewModel = viewModel, | |
| state = state | |
| ) | |
| } |
Comment on lines
205
to
220
| SignUpButtonView( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| isEnabled = state.isItemSelected, | ||
| visiblePopUpError = state.visiblePopUpError, | ||
| popUpErrorMessage = state.popUpErrorMessage, | ||
| visiblePopUpErrorChanged = { visiblePopUpError -> | ||
| viewModel.visiblePopUpErrorChanged(visiblePopUpError) | ||
| }, | ||
| onCreateUniversity = { | ||
| viewModel.createUniv(state.selectedUniv, state.gradeInfor) | ||
| }, | ||
| navigateToSignUpUniversity = { agencyName, agencyType -> }, | ||
| agencyName = agencyName, | ||
| agencyType = agencyType, | ||
| pageType = 2 | ||
| ) |
There was a problem hiding this comment.
등록하기 버튼의 padding 과 corner radius 값이 디자인과 달라요
| 현재 | 디자인 |
|---|---|
 |
 |
| color = Gray06 | ||
| ) | ||
|
|
||
| SearchUnivView( |
There was a problem hiding this comment.
대학 아이템 목록에서 다음과 같은 버그가 있어요!
- 선택 안 된 다른 학교 클릭 -> 등록하기 disabled 됨
- 이미 선택된 학교 클릭 -> 계속 선택된 학교로 표시
KakaoTalk_Video_2024-12-16-20-34-50.mp4
Comment on lines
49
to
57
| @Composable | ||
| fun SignUpUniversity( | ||
| navigateToLedger : () -> Unit, | ||
| navigateToAgency : () -> Unit, | ||
| navigateUp : () -> Unit, | ||
| agencyName : String, | ||
| agencyType: AgencyType, | ||
| viewModel: SignUpUniversityViewModel = hiltViewModel() | ||
| ){ |
There was a problem hiding this comment.
해당 화면에서 동아리 or 학생회를 등록할 때 다음과 같은 버그가 있어요!
KakaoTalk_Video_2024-12-16-20-47-59.mp4
jhg3410
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
회원가입 플로우 개선하였습니다.
작업내용
스크린샷