You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But we forget to destroy the object *dst that is already in this place.
So some object with non-trivial destructor will fail to clean up.
e.g. std::shared_ptr.
The text was updated successfully, but these errors were encountered:
For a general vector implementation, we shall not rely on the behavior of the element's move constructor.
Because sometimes the move constructor is not implemented and falls back to the copy constructor.
In that case, the element in dst is never moved or destroyed.
Here we construct a new object in-place.
https://github.com/open-mmlab/CLUE/blob/6c2f4707e564dbc53d616eb70f6a913a42552941/include/clue/fast_vector.hpp#L78
But we forget to destroy the object
*dst
that is already in this place.So some object with non-trivial destructor will fail to clean up.
e.g.
std::shared_ptr
.The text was updated successfully, but these errors were encountered: