Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode Persistence on Refresh #1110

Closed
4 of 7 tasks
PATILYASHH opened this issue Oct 30, 2024 · 9 comments · Fixed by #1116
Closed
4 of 7 tasks

Dark Mode Persistence on Refresh #1110

PATILYASHH opened this issue Oct 30, 2024 · 9 comments · Fixed by #1116
Assignees
@PATILYASHH
Labels
bug Something isn't working gssoc-ext These issue/pull request will be considered for GSSOC'24 Extd hacktoberfest-accepted Hacktoberfest level1 Beginner level issues/pull requests

Comments

@PATILYASHH
Copy link
Contributor

Description

When a user switches to dark mode, the mode resets to light mode upon refreshing the website. Ideally, the website should retain the user's selected mode (dark or light) even after the page reloads.

Steps to Reproduce

  1. Go to the website.
  2. Switch to dark mode.
  3. Refresh the page.
  4. Observe that the website reverts to light mode.

Expected Behavior

After a user switches to dark mode, the website should remain in dark mode upon refresh or navigating between pages.

Actual Behavior

No response

Screenshots

ML.Fusion.Lab.-.Google.Chrome.2024-10-30.21-51-44.mp4

Additional Information

No response

What browser are you seeing the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge

Checklist
@PATILYASHH PATILYASHH added the bug Something isn't working label Oct 30, 2024
@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Oct 30, 2024 •
edited
Loading

@PATILYASHH assigning this issue to you.

Make sure to complete this fast.

this will be the only issue i am assigning to you.

As i have said earlier this project and will be inactive from tonight due to some of my work.

so make sure to complete this.

@vivekvardhan2810 vivekvardhan2810 added level1 Beginner level issues/pull requests gssoc-ext These issue/pull request will be considered for GSSOC'24 Extd hacktoberfest-accepted Hacktoberfest labels Oct 30, 2024
@PATILYASHH
Copy link
Contributor Author

Thank you sir I will do it now

@vivekvardhan2810
Copy link
Member

@PATILYASHH have you done with the task.

@vivekvardhan2810
Copy link
Member

@PATILYASHH before creating the pull request make sure to update your branch and then commit the changes, and then create the Pull request.

so that you can avoid merge conflicts.

@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Oct 30, 2024 •
edited
Loading

@PATILYASHH please complete this task.

As i have said earlier this project and will be inactive from tonight due to some of my work.

@vivekvardhan2810
Copy link
Member

@PATILYASHH have you done with the task.

@PATILYASHH
Copy link
Contributor Author

yes sir i will do PR in 15 minutes

@PATILYASHH
Copy link
Contributor Author

I can't do PR because of no electricity I will do it whenever the light comes back sorry for this , I will try my best

@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Oct 31, 2024 •
edited
Loading

Okay @PATILYASHH when electricity comes back, make sure to complete it and Create the PR.

As i have said earlier this project and will be inactive from today afternoon due to some of my work.

@PATILYASHH PATILYASHH mentioned this issue Oct 31, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PATILYASHH PATILYASHH

Labels
bug Something isn't working gssoc-ext These issue/pull request will be considered for GSSOC'24 Extd hacktoberfest-accepted Hacktoberfest level1 Beginner level issues/pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Local storage to dark mode light mode PATILYASHH/ML-Fusion-Lab-Website
2 participants
@vivekvardhan2810 @PATILYASHH