Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors module with custom tables #576

Open
NatalieRees opened this issue Aug 9, 2023 · 0 comments
Open

Colors module with custom tables #576

NatalieRees opened this issue Aug 9, 2023 · 0 comments
Assignees
Labels
summer_school issues affecting lab exercises for the upcoming MESA summer school test_suite Issue in test_suite case

Comments

@NatalieRees
Copy link

Describe the bug

For the MESA Summer school we were trying to implement a custom colors table as one of the exercises.
This table has bolometric corrections for a range of Teff and logg at M_div_H=-0.5.
We followed the implementation as demonstrated by the custom_colors test_suite example however found the get_abs_mag_by_name routine was always returning -1d99 so seemed to be extrapolating when our values were definitely in the data range of the table.
I've realised the problem is that when you only have one value for M_div_H, even if the value you supply is exactly equal to it then it will be classed as extrapolation and return -1d99.
To check this I made a fudged data table with duplicated data at both M_div_H=-0.4 and M_div_H=-0.6 which then returns the expected values for M_div_H=-0.5.
I have attached the work directory including the fudged data table which works as well as the original table which doesn't

custom_colors_bug_report.zip
fehm050_Av03.HST_WFPC2.zip

@mjoyceGR mjoyceGR added test_suite Issue in test_suite case summer_school issues affecting lab exercises for the upcoming MESA summer school labels Aug 9, 2023
@mjoyceGR mjoyceGR self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer_school issues affecting lab exercises for the upcoming MESA summer school test_suite Issue in test_suite case
Projects
None yet
Development

No branches or pull requests

2 participants