Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine.background.to.remove error in readme #6

Open
CebolaLab opened this issue Dec 13, 2024 · 0 comments
Open

determine.background.to.remove error in readme #6

CebolaLab opened this issue Dec 13, 2024 · 0 comments

Comments

@CebolaLab
Copy link

Hi,

I think the suggested command on your readme page may have an error? It reads:

ambientProfile = determine.background.to.remove(fullMatrix, cellMatrix, emptyDropletCutoff, contaminationChanceCutoff)
cellMatrix     = remove.background(cellMatrix, ambientProfile)

Yet when I look at the determine.background.to.remove function, I see:

function (fullCellMatrix, emptyDropletCutoff, contaminationChanceCutoff) 
{
    backGroundMax = as.vector(qlcMatrix::rowMax(fullCellMatrix[, 
        Matrix::colSums(fullCellMatrix) < emptyDropletCutoff]))
    names(backGroundMax) = rownames(fullCellMatrix)
    nEmpty = table((Matrix::colSums(fullCellMatrix) < emptyDropletCutoff) & 
        (Matrix::colSums(fullCellMatrix) > 0))[2]
    occurences = Matrix::rowSums(fullCellMatrix[, Matrix::colSums(fullCellMatrix) < 
        emptyDropletCutoff] != 0)
    probabiltyCellContaminationPerGene = occurences/nEmpty
    backGroundMax[probabiltyCellContaminationPerGene < contaminationChanceCutoff] = 0
    return(backGroundMax)
}

Which does not have cellMatrix as an input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant