-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add fit-to-height option to web or React component #1782
Comments
Fit to height is not really supported by H5P out-of-the-box, as far as I know. If you use the iframe mode, you'll already have found out that this H5P sizes to width, but not to height. I totally agree that this is a problem that can be annoying for users. My thoughts on how to solve the problem:
|
Hey, Would it be a possible future iteration to switch between fit to height <> fit to width? Because currently the player uses the width it gets and adjusts the height as far as I understand? Maybe this could be a configuration to set the height and it adjusts the width according to the aspect ratio? Anyway, I would be happy to hear once the desktop player app is ready! Will this maybe even support offline usage? Edit: Should I close this ticket for now? |
The desktop player will work fully offline and will play any h5p file. We can add "fit to height" resizing as a feature request and leave the ticket open for it. I can't make any promises but it might make sense to add this to the webcomponent or the react component. |
Hey!
We have integrated the H5PPlayerUI from the h5p-react package into our website.
The size of the H5P component depends on it's content, which is great. However, sometimes the content gets higher than the max screen height. For some content types this is a bit annoying since users have to scroll to interact with it.
Is there a way to limit the maximum height of the H5P Iframe to a certain value? We would need something like a calculated value based on the viewport height - navigation bars (e.g.
calc(100vh - 74px)
).I couldn't find a way to control that in the documentation.
Thanks a lot already!
The text was updated successfully, but these errors were encountered: