Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are duplicated code in the file "glTF2.cpp" #3

Open
timi-liuliang opened this issue May 8, 2018 · 0 comments
Open

There are duplicated code in the file "glTF2.cpp" #3

timi-liuliang opened this issue May 8, 2018 · 0 comments

Comments

@timi-liuliang
Copy link

In the file "glTF2.cpp", between line 384-398

    // bufferView
    if (accessors[i].find("bufferView") != accessors[i].end()) {
        if (!accessors[i]["bufferView"].is_number()) {
            throw MisformattedExceptionNotNumber("accessors[i][bufferView]");
        }

        asset.accessors[i].bufferView = accessors[i]["bufferView"].get<int32_t>();
    }

    // bufferView
    if (accessors[i].find("bufferView") != accessors[i].end()) {
        if (!accessors[i]["bufferView"].is_number()) {
            throw MisformattedExceptionNotNumber("accessors[i][bufferView]");
        }

        asset.accessors[i].bufferView = accessors[i]["bufferView"].get<int32_t>();
    }

The second time of "bufferView" parse isn't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant