Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie broker subscriptions to 'enabled' statuses? #9

Open
astrobokonon opened this issue Sep 17, 2019 · 1 comment
Open

Tie broker subscriptions to 'enabled' statuses? #9

astrobokonon opened this issue Sep 17, 2019 · 1 comment
Assignees
Labels
low priority wontfix This will not be worked on

Comments

@astrobokonon
Copy link
Member

In the current incarnation, all the topics are gathered up in one place at the initial startup as defined in the configuration file. That's fine!

What's less-fine, though is that the listener is set as well, and it'll parse anything/everything regardless of the value of the 'enabled' key in the device configuration.

That means in practice, the listener/parser for things like the LOIS status topics are always on. I don't know yet if that's the preferred behavior. It's probably fine? But I wanted to make a note here to remind myself of this in the future.

@astrobokonon astrobokonon added question Further information is requested low priority labels Sep 17, 2019
@astrobokonon astrobokonon self-assigned this Sep 17, 2019
@astrobokonon astrobokonon added the wontfix This will not be worked on label Nov 25, 2019
@astrobokonon
Copy link
Member Author

Thinking about this more, it is fine, so long as there's really only one consumer of the temperatures. When I had the temporary listener still in Iago, and was standing up Nora, then it was a problem.

I'll leave this open for a little longer, but I'll tag it as wontfix for now.

@astrobokonon astrobokonon removed the question Further information is requested label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant