Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Title Row to the Sidebar #1861

Open
G2HJei opened this issue Jul 21, 2024 · 1 comment
Open

Move Title Row to the Sidebar #1861

G2HJei opened this issue Jul 21, 2024 · 1 comment
Labels
not planned This will not be worked on in the immediate future

Comments

@G2HJei
Copy link

G2HJei commented Jul 21, 2024

The Game Title row can be moved to the right side - under the settings buttons. This will allow for extra vertical space to show maximum amount of the main game components' height. Currently their height is capped to 95vh with extra margins, but moving the title bar will allow to utilize 100vh.

Additionally the current HTML structure goes against the Bootstrap principles as the main game components are in a row containing another row (inside are the map, log, chat, etc) and a col-12 (title elements) at the same time, as well as the fixed-position elements. This messes up the margins of the components and can be eliminated by moving the Game Title row to the right as well.

snr-title
RED: First row in the game-container. Inside it are the title, all game components and fixed-position elements.
YELLOW: A col-12 title elements which I propose to be moved to the right.
GREEN: The main game components (map, log, chat, tracks etc). There are two nested rows here which can be easily corrected when the title is moved to the right.
BLUE: The proposed position fo the game components, part of the title. A suitable design should be created to include either smaller badges for the game settings or a whole popover with details to be displayed on click. The title text itself can be vertically wrapped or shown as a tooltip/in the popover.

Side note: The lobby title can be kept as it is as height is not an issue in it.

@gereon77
Copy link
Collaborator

gereon77 commented Aug 5, 2024

The code for this can be found in EntireGameComponent. But to be honest, I like a readable title bar and feel like long game titles look weird. Additionally other game hints, like Tides of Battle, etc get lost on the right...

And what do we with small screens?

grafik

For now, I put it as not planned...

@gereon77 gereon77 added the not planned This will not be worked on in the immediate future label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not planned This will not be worked on in the immediate future
Projects
None yet
Development

No branches or pull requests

2 participants