Implement updated design notification banners #7
Conversation
|
You might already be aware, but if you're not, to fix the CI pipeline: Liquipedia/ResourceLoaderArticles@d23ef7c |
I didn't know yet, thanks a lot! |
liquidely
changed the title
|
We should probably add js stylechecking via eslint, we also should get a migration to remove the color (style) column from the database. |
Added eslint |
There was a problem hiding this comment.
Suggestion for cleaner ESLint config using ES2020 instead.
Also, I know there's no jQuery in this project, but if we ever wanted to use any, down the road, would be useful to add (then or now) it to package.json so that the jquery settings in the linter actually do something and to provide IDE syntax highlighting and static analysis.
This will apply the new design to all wikis!
In this PR:
Closes ticket
Can be tested here
PR to remove SiteNotices.js Liquipedia/Lua-Modules#4249