Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intended usage of role/position in transfer rows #5121

Open
mbergen opened this issue Nov 22, 2024 · 4 comments
Open

Clarify intended usage of role/position in transfer rows #5121

mbergen opened this issue Nov 22, 2024 · 4 comments
Labels
c: transfer g: honorofkings Honor of Kings / Arena of Valor g: leagueoflegends League of Legends g: mobilelegends Mobile Legends: Bang Bang g: overwatch Overwatch g: smite Smite g: wildrift League of Legends: Wild Rift

Comments

@mbergen
Copy link
Collaborator

mbergen commented Nov 22, 2024

Currently, some wikis have different usages

  • LOL, MLBB, HOK, WR, Smite: Input only position, for both ingame positions as well as staff roles
  • OW: Input both position and role for staff roles, position only for ingame roles
  • Other wikis: Use position for ingame positions, role for staff (and player, e.g. inactive) roles

This should be aligned. Proposed solution:
Use what most wikis already do;

  • Restrict the position input to only ingame positions
  • Introduce separate icon module RoleIcon/data, which will take the current definition of "position" icons that would become roles (manager, coach, etc.). This would be used to display icons in case there is no position input, but a role with matching icon. (keeps the wikis that have these icons backwards-compatible)
  • Bot-edit the listed wikis to move non-ingame positions to role input
@mbergen
Copy link
Collaborator Author

mbergen commented Nov 22, 2024

@hjpalpha @ElectricalBoy thoughts?

@mbergen mbergen added c: transfer g: wildrift League of Legends: Wild Rift g: mobilelegends Mobile Legends: Bang Bang g: overwatch Overwatch g: honorofkings Honor of Kings / Arena of Valor g: leagueoflegends League of Legends g: smite Smite labels Nov 22, 2024
@hjpalpha
Copy link
Collaborator

hjpalpha commented Nov 22, 2024

valid idea

i will not be able to help with it in the next weeks though

@ElectricalBoy
Copy link
Contributor

I don't see a reason not to make the syntax the same across the board

not really sure why I am pinged here though :)

@mbergen
Copy link
Collaborator Author

mbergen commented Nov 22, 2024

not really sure why I am pinged here though :)

I thought you were talking about his on discord, might have confused you with Laus tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: transfer g: honorofkings Honor of Kings / Arena of Valor g: leagueoflegends League of Legends g: mobilelegends Mobile Legends: Bang Bang g: overwatch Overwatch g: smite Smite g: wildrift League of Legends: Wild Rift
Projects
None yet
Development

No branches or pull requests

3 participants