Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lower and upper nodes in match2 #4648

Open
Rathoz opened this issue Aug 26, 2024 · 0 comments
Open

Rename lower and upper nodes in match2 #4648

Rathoz opened this issue Aug 26, 2024 · 0 comments

Comments

@Rathoz
Copy link
Collaborator

Rathoz commented Aug 26, 2024

Several fields in match2bracketdata are called lower... or upper.... Because the naming lower/upper is normally for lower/upper bracket, while here it refers to connects ("left"/"right").

Hence they should be renamed to make it easier to under. Could be for example child/parent as orignally suggested in #797, or something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant