Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grand Final map increased for Match 2 Brackets #4293

Open
FenrirWulf opened this issue May 27, 2024 · 2 comments
Open

Grand Final map increased for Match 2 Brackets #4293

FenrirWulf opened this issue May 27, 2024 · 2 comments
Labels

Comments

@FenrirWulf
Copy link
Collaborator

FenrirWulf commented May 27, 2024

Based off an idea concept from Rainbow Six: https://discord.com/channels/93055209017729024/315607343331278848/1244481542403915808

PaTcHiZzEl — 5/26/2024 at 7:45 PM (PDT)

I have a suggestion:

In the Copy Paste bracket code generator, could there be a parameter for setting Number of Maps in the Grand Finals separate from the rest of the bracket? In almost every bracket I create, the # of maps in the final is greater than the rest of the bracket, so I end up having to generate code twice.

Not important but would be a nice QoL``

Often times Grand Finals of brackets have an increased map pool than the preceeding rounds. So a Grand Final might be a Bo9 instead of Bo5.

Would need to know what the Grand Finals Map count is in advanced (probably a new form field), then actually apply it. This would also change the map vetos process

@hjpalpha
Copy link
Collaborator

please copy the discord comment over here so when the discord link breaks we still know what this is about

@hjpalpha
Copy link
Collaborator

hjpalpha commented May 27, 2024

possible solution

  1. adjust commons to pass along bracketdata in
    local match = empty and '' or WikiSpecific.getMatchCode(bestof, mode, matchIndex, opponents, args)
  2. adjust all customs to avoid annotation errors
  3. add a function (to /base imo) that checks if a match has has 3rd place / reset match info in its bracketdata — this indicates a finals match fwiw
  4. adjust the r6 custom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants