Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor various Infoboxes into Infobox Unit #3963

Open
5 tasks
FenrirWulf opened this issue Feb 9, 2024 · 4 comments
Open
5 tasks

Refactor various Infoboxes into Infobox Unit #3963

FenrirWulf opened this issue Feb 9, 2024 · 4 comments
Assignees

Comments

@FenrirWulf
Copy link
Collaborator

We have various infoboxes that can/should be refactored into 1 Infobox as the base instead of multiple infoboxes.

  • Hero
  • Character
  • Champion
  • Operator
  • Agent
@hjpalpha
Copy link
Collaborator

hjpalpha commented Feb 9, 2024

only unit and character exist on the git repo
and they are quite different (you created the character one due to that >2 years ago)

champion, operator and agent should all be able to use one of the two as a base

@Rathoz
Copy link
Collaborator

Rathoz commented Feb 9, 2024

Unit and Character should be kept separate I believe. Character is generally more like a Champion/Hero/Agent/Operator; while Unit is something that you buy in an RTS, like a Space Marine Terran Marine

@hjpalpha
Copy link
Collaborator

hjpalpha commented Feb 9, 2024

Unit and Character should be kept separate I believe. Character is generally more like a Champion/Hero/Agent/Operator; while Unit is something that you buy in an RTS, like a Space Marine Terran Marine

fun fact the german translation calls them "Space Marine" instead of just "Marine" (like in the neglish version)

@FenrirWulf
Copy link
Collaborator Author

I mean.. sure.. but we have already combined Champion & God infoboxes into Unit. Additionally, F1 uses Unit for Engine and Car, and OW is currently getting its Hero Infobox based off Unit as well.

The base version according to our current practice isnt that important. The more important part is the custom module built for the wiki. Since we can always add wiki specific LPDB saving, or adjust the display of things.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants