Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: performance issue on large single page #667

Open
1 task done
Luciogi opened this issue Apr 19, 2024 · 14 comments
Open
1 task done

[Bug]: performance issue on large single page #667

Luciogi opened this issue Apr 19, 2024 · 14 comments
Assignees
Labels
bug Something isn't working confirmed

Comments

@Luciogi
Copy link
Contributor

Luciogi commented Apr 19, 2024

What happened?

A bug happened!
when moving around on canvas

Platform Tested:
WPA(firefox)
Android

File: https://github.com/LinwoodDev/Butterfly/files/15015668/butterfly.bfly.zip

Version

2.1.0-rc.0

Platform

Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Luciogi Luciogi added the bug Something isn't working label Apr 19, 2024
@github-project-automation github-project-automation bot moved this to 📕 Todo in Butterfly Apr 19, 2024
@CodeDoctorDE
Copy link
Member

thanks for reporting, i tested it myself and on firefox it is very buggy, on windows it seems to handle it (maybe because the pc is better than a phone)

@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 19, 2024

Umm After comparing Chromium and firefox (on Laptop with power mode on performance) both give nearly same performance when moving around on canvas. From my previous observations I think so my laptop was running on power saving mode

I think that, tools like path eraser and eraser are causing performance issue

@CodeDoctorDE
Copy link
Member

Okay thanks. I just wanted to be sure I could reproduce this behavior.
I will look at it and try to fix it

@Luciogi
Copy link
Contributor Author

Luciogi commented May 7, 2024

path eraser tool when delete an element whole visible area is canvas is rerendered.
I am also not sure if it refresh objects what are not visible on screen

bdf04323-5fac-49fe-aa2b-3007df3760ed.mp4

@CodeDoctorDE
Copy link
Member

Which version do you use currently?

@Luciogi
Copy link
Contributor Author

Luciogi commented May 7, 2024

2.1.0-rc.3
just installed latest apk from gitbub actions

@CodeDoctorDE
Copy link
Member

Okay thanks, i will check it

@CodeDoctorDE
Copy link
Member

fixed in 2.1.1-rc.1

@Luciogi
Copy link
Contributor Author

Luciogi commented May 20, 2024

32e6522d-66d6-4d44-8b4a-aa428eccbfa1.mp4
  • the easer path pointer is also too slow
  • Erasing path, misses paths , it could be due to slowness of pointer

@CodeDoctorDE
Copy link
Member

thanks for testing, I will try to improve this a bit

@coordinatio
Copy link

coordinatio commented Oct 28, 2024

I have also started hitting this issue.
It seems that after some time, initiation of a new line starts taking time. In the same time, the drawing process itself seems snappy.
Here is the screen recording illustrating what I face: https://youtube.com/shorts/7eW-GMl0ZOI?feature=share
Here is the note file from the video: output.bfly.zip

Seems like there is some logic going when a line being initiated, and that logic is somehow badly dependent on the number of lines present on the page.

My device is Samsung Galaxy Z Fold 5, must be quite performant for the time, so hardware is not the case.
Butterfly's version: 2.2.1

@CodeDoctorDE
Copy link
Member

Okay, thanks for reporting and an example file.
I have some ideas where these long delays are coming from. I will test them and come back to you

@github-project-automation github-project-automation bot moved this from 📕 Todo to ✅ Done in Butterfly Oct 30, 2024
@CodeDoctorDE CodeDoctorDE reopened this Oct 30, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🚧 In Progress in Butterfly Oct 30, 2024
@CodeDoctorDE
Copy link
Member

i added some performance improvements but if this doesn't help, you could disable autosaving in the settings

@pisceswb
Copy link

pisceswb commented Nov 4, 2024

i added some performance improvements but if this doesn't help, you could disable autosaving in the settings

Disabling auto-save can effectively prevent the lagging phenomenon of handwritten pen strokes, especially on pages with a lot of handwritten content. However, it would be helpful to add a feature that automatically saves the content upon exiting the page to avoid losing notes. Thank you.
@CodeDoctorDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
Status: 🚧 In Progress
Development

No branches or pull requests

4 participants