Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need validation to all GenerativeDistribution and Function implemented correctly #502

Open
walterxie opened this issue Jul 4, 2024 · 0 comments
Open

Need validation to all GenerativeDistribution and Function implemented correctly #502

walterxie opened this issue Jul 4, 2024 · 0 comments
Labels
critical change the bug fix or new feature will significant change the code enhancement New feature or request

Comments

@walterxie
Copy link
Collaborator

Need validation to all GenerativeDistribution and Function implemented correctly.

They require either setParams or setter, otherwise the re-sampling will be broken. Same to getParams. So it will be nice to check each class after registration, throw Exception if any of them is not implemented correctly by a developer.
@walterxie walterxie added enhancement New feature or request critical change the bug fix or new feature will significant change the code labels Jul 4, 2024
@walterxie walterxie pinned this issue Jul 7, 2024
walterxie added a commit that referenced this issue Jul 29, 2024
@walterxie
correct implementation of Sequence #511 #502
b882f6d
walterxie added a commit that referenced this issue Jul 29, 2024
@walterxie
fix unit test #511 #502
ccae8f1
walterxie added a commit that referenced this issue Jul 29, 2024
@walterxie
Binomial missing setter #502
e512795
walterxie added a commit that referenced this issue Oct 2, 2024
@walterxie
JUnit test to validate if all GenerativeDistribution and Function imp…
a6e0c33 
…lemented correctly #502
walterxie added a commit that referenced this issue Oct 2, 2024
@walterxie
JUnit test to validate if all GenerativeDistribution and Function imp…
5e1b9f8 
…lemented correctly #502
walterxie added a commit that referenced this issue Oct 2, 2024
@walterxie
validate GeneratorInfo #502
7e94d80
walterxie added a commit that referenced this issue Oct 29, 2024
@walterxie
unregister invalid Multinomial, and add descriptions in the unit test #…
8cbdc48 
…502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical change the bug fix or new feature will significant change the code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walterxie