Merge pull request #2590 from LibreSign/feature/organize-install-files

Organize install files
LibreSign · Mar 26, 2024 · 71df343 · 71df343
2 parents f1bd453 + a9dd0b4
commit 71df343
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 15 deletions.
diff --git a/lib/Command/Base.php b/lib/Command/Base.php
@@ -25,7 +25,7 @@
 namespace OCA\Libresign\Command;
 
 use OC\Core\Command\Base as CommandBase;
-use OCA\Libresign\Service\InstallService;
+use OCA\Libresign\Service\Install\InstallService;
 use Psr\Log\LoggerInterface;
 
 class Base extends CommandBase {

diff --git a/lib/Command/Configure/Check.php b/lib/Command/Configure/Check.php
@@ -25,7 +25,7 @@
 namespace OCA\Libresign\Command\Configure;
 
 use OC\Core\Command\Base;
-use OCA\Libresign\Service\ConfigureCheckService;
+use OCA\Libresign\Service\Install\ConfigureCheckService;
 use OCP\IConfig;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Helper\TableCell;

diff --git a/lib/Command/Developer/Reset.php b/lib/Command/Developer/Reset.php
@@ -2,7 +2,9 @@
 
 declare(strict_types=1);
 /**
- * @copyright Copyright (c) 2020 Joas Schilling <coding@schilljs.com>
+ * @copyright Copyright (c) 2023 Vitor Mattos <vitor@php.rio>
+ *
+ * @author Vitor Mattos <vitor@php.rio>
  *
  * @license GNU AGPL version 3 or any later version
  *

diff --git a/lib/Controller/AdminController.php b/lib/Controller/AdminController.php
@@ -28,8 +28,8 @@
 use OCA\Libresign\Exception\LibresignException;
 use OCA\Libresign\Handler\CertificateEngine\Handler as CertificateEngineHandler;
 use OCA\Libresign\Helper\ConfigureCheckHelper;
-use OCA\Libresign\Service\ConfigureCheckService;
-use OCA\Libresign\Service\InstallService;
+use OCA\Libresign\Service\Install\ConfigureCheckService;
+use OCA\Libresign\Service\Install\InstallService;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\NoCSRFRequired;

diff --git a/lib/Handler/CertificateEngine/CfsslHandler.php b/lib/Handler/CertificateEngine/CfsslHandler.php
@@ -32,7 +32,7 @@
 use OCA\Libresign\Exception\LibresignException;
 use OCA\Libresign\Handler\CfsslServerHandler;
 use OCA\Libresign\Helper\ConfigureCheckHelper;
-use OCA\Libresign\Service\InstallService;
+use OCA\Libresign\Service\Install\InstallService;
 use OCP\AppFramework\Services\IAppConfig;
 use OCP\Files\AppData\IAppDataFactory;
 use OCP\IConfig;

diff --git a/lib/Migration/Version8000Date20230730032402.php b/lib/Migration/Version8000Date20230730032402.php
@@ -26,7 +26,7 @@
 namespace OCA\Libresign\Migration;
 
 use Closure;
-use OCA\Libresign\Service\InstallService;
+use OCA\Libresign\Service\Install\InstallService;
 use OCP\AppFramework\Services\IAppConfig;
 use OCP\Migration\IOutput;
 use OCP\Migration\SimpleMigrationStep;

diff --git a/lib/Service/ConfigureCheckService.php → ...Service/Install/ConfigureCheckService.php b/lib/Service/ConfigureCheckService.php → ...Service/Install/ConfigureCheckService.php
@@ -22,7 +22,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-namespace OCA\Libresign\Service;
+namespace OCA\Libresign\Service\Install;
 
 use OC\SystemConfig;
 use OCA\Libresign\Handler\CertificateEngine\Handler as CertificateEngine;

diff --git a/lib/Service/InstallService.php → lib/Service/Install/InstallService.php b/lib/Service/InstallService.php → lib/Service/Install/InstallService.php
@@ -22,7 +22,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-namespace OCA\Libresign\Service;
+namespace OCA\Libresign\Service\Install;
 
 use InvalidArgumentException;
 use OC;

diff --git a/tests/Unit/Service/InstallServiceTest.php b/tests/Unit/Service/InstallServiceTest.php
@@ -24,7 +24,7 @@
 namespace OCA\Libresign\Tests\Unit\Service;
 
 use OCA\Libresign\Handler\CertificateEngine\Handler as CertificateEngineHandler;
-use OCA\Libresign\Service\InstallService;
+use OCA\Libresign\Service\Install\InstallService;
 use OCP\AppFramework\Services\IAppConfig;
 use OCP\Files\AppData\IAppDataFactory;
 use OCP\Files\IRootFolder;

diff --git a/tests/Unit/TestCase.php b/tests/Unit/TestCase.php
@@ -180,8 +180,8 @@ public function deleteUserIfExists($username): void {
 	}
 
 	private function getBinariesFromCache(): void {
-		/** @var \OCA\Libresign\Service\InstallService */
-		$install = \OC::$server->get(\OCA\Libresign\Service\InstallService::class);
+		/** @var \OCA\Libresign\Service\Install\InstallService */
+		$install = \OC::$server->get(\OCA\Libresign\Service\Install\InstallService::class);
 		$appPath = $install->getFullPath();
 		$cachePath = preg_replace('/\/.*\/appdata_[a-z0-9]*/', \OC::$server->getTempManager()->getTempBaseDir(), $appPath);
 		if (!file_exists($cachePath)) {
@@ -194,8 +194,8 @@ private function getBinariesFromCache(): void {
 	}
 
 	private function backupBinaries(): void {
-		/** @var \OCA\Libresign\Service\InstallService */
-		$install = \OC::$server->get(\OCA\Libresign\Service\InstallService::class);
+		/** @var \OCA\Libresign\Service\Install\InstallService */
+		$install = \OC::$server->get(\OCA\Libresign\Service\Install\InstallService::class);
 		$appPath = $install->getFullPath();
 		if (!is_readable($appPath)) {
 			return;

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -90,7 +90,7 @@
       <code>private</code>
     </UndefinedClass>
   </file>
-  <file src="lib/Service/InstallService.php">
+  <file src="lib/Service/Install/InstallService.php">
     <UndefinedClass occurrences="1">
       <code>Process</code>
     </UndefinedClass>