diff --git a/lib/Activity/Provider/SignRequest.php b/lib/Activity/Provider/SignRequest.php index 8657574a1f..6ab49f15e4 100644 --- a/lib/Activity/Provider/SignRequest.php +++ b/lib/Activity/Provider/SignRequest.php @@ -95,7 +95,7 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null): private function getParsedSubject($l, $subject) { if ($subject === 'new_sign_request') { - return $l->t('{from} invited you to sign {file}'); + return $l->t('{from} requested your signature on {file}'); } elseif ($subject === 'update_sign_request') { return $l->t('{from} made changes on {file}'); } diff --git a/lib/Notification/Notifier.php b/lib/Notification/Notifier.php index acb0cfe632..a22f354ac9 100644 --- a/lib/Notification/Notifier.php +++ b/lib/Notification/Notifier.php @@ -98,7 +98,7 @@ private function parseSignRequest( $notification ->setIcon($this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg'))) ->setLink($parameters['file']['link']); - $subject = $l->t('{from} invited you to sign {file}'); + $subject = $l->t('{from} requested your signature on {file}'); $notification->setParsedSubject( str_replace( ['{from}', '{file}'], diff --git a/tests/integration/features/bootstrap/FeatureContext.php b/tests/integration/features/bootstrap/FeatureContext.php index ad82583336..7993aad7c0 100644 --- a/tests/integration/features/bootstrap/FeatureContext.php +++ b/tests/integration/features/bootstrap/FeatureContext.php @@ -353,11 +353,11 @@ public function iFetchTheSignerUuidFromNotification(): void { $found = array_filter( $data, function ($notification) { - return $notification['subject'] === 'admin invited you to sign document'; + return $notification['subject'] === 'admin requested your signature on document'; } ); if (empty($found)) { - throw new Exception('Notification with the subject [admin invited you to sign document] not found'); + throw new Exception('Notification with the subject [admin requested your signature on document] not found'); } $found = current($found); diff --git a/tests/integration/features/page/sign_identify_account.feature b/tests/integration/features/page/sign_identify_account.feature index fc7a62e2e3..cb3b1ac044 100644 --- a/tests/integration/features/page/sign_identify_account.feature +++ b/tests/integration/features/page/sign_identify_account.feature @@ -17,7 +17,7 @@ Feature: page/sign_identify_account And sending "get" to ocs "/apps/notifications/api/v2/notifications" Then the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| When sending "get" to ocs "/apps/libresign/api/v1/file/list" And the response should have a status code 200 And the file to sign contains @@ -71,7 +71,7 @@ Feature: page/sign_identify_account And sending "get" to ocs "/apps/notifications/api/v2/notifications" Then the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| When sending "get" to ocs "/apps/libresign/api/v1/file/list" And the response should have a status code 200 And the file to sign contains diff --git a/tests/integration/features/sign/request.feature b/tests/integration/features/sign/request.feature index 7d9ca1a8b5..b202eade3f 100644 --- a/tests/integration/features/sign/request.feature +++ b/tests/integration/features/sign/request.feature @@ -198,11 +198,11 @@ Feature: request-signature Then sending "get" to ocs "/apps/notifications/api/v2/notifications" And the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| When sending "get" to ocs "/apps/activity/api/v2/activity/libresign?since=0" Then the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| Scenario: Request to sign with error using account as identifier with invalid email Given as user "admin" @@ -257,7 +257,7 @@ Feature: request-signature And sending "get" to ocs "/apps/notifications/api/v2/notifications" Then the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| And there should be 0 emails in my inbox Scenario: Request to sign with success using email as identifier @@ -315,7 +315,7 @@ Feature: request-signature And sending "get" to ocs "/apps/notifications/api/v2/notifications" Then the response should be a JSON array with the following mandatory values | key | value | - | ocs | (jq).data\|.[].subject == "admin invited you to sign document"| + | ocs | (jq).data\|.[].subject == "admin requested your signature on document"| And there should be 1 emails in my inbox And I open the latest email to "signer1@domain.test" with subject "LibreSign: There is a file for you to sign"