Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions & Bodyweight in Statistics dates are off by one #283

Closed
Sveske-Juice opened this issue Oct 6, 2024 · 3 comments · Fixed by #284
Closed

Sessions & Bodyweight in Statistics dates are off by one #283

Sveske-Juice opened this issue Oct 6, 2024 · 3 comments · Fixed by #284

Comments

@Sveske-Juice
Copy link
Contributor

Sveske-Juice commented Oct 6, 2024

I have two Workout sessions, where i log my bodyweight. 1st sessions i oct. 5 @ 80kg bw & 2nd session is oct. 6 @ 78.5kg bw.

The Bodyweight graph (StatGraphCardContent) shows the day is off by one. At oct. 4 it shows 80kg and on oct. 5 it shows 78.5kg. So they are 1 day early.
Screenshot_20241006-173702_LiftLog

The Sessions graph also is off by one (1 day early).

The issue does not appear on the graph from the UnpinnedExercisesToShow, only the Bodyweight and Sessions graphs.

I tried exporting the data to see if the dates are stored wrong, but I couldn't find the bodyweight data in the exported data (and didn't know how to properly de-serialze it either way, which could probably be seen if #244 is implemented).

Some debug information:
Timezone: Europe/Copenhagen or UTC+2
LiftLog version: 2.18.3
Android version: 14 kernel: 5.4.280

@Sveske-Juice
Copy link
Contributor Author

Another bug that is probably not related to this one: When registering a freeform workout without any exercises other than a body weight, then the body weight data is not included in the Body weight graph.

I did this because before installing this app, i registered my body weight in my notes, but thought i should move them to the app as a freeform workout with just the body weight registered. A workaround is to add a dummy exercise to the freeform workout, but it would be nice if this wasn't required. This should probably be opened in a separate issue.

@LiamMorrow
Copy link
Owner

Thanks for the report! I've tried to avoid timezone issues by only working with LocalDate/LocalTimes without timezone info, but obviously the charts did not get the memo and are treating them as UTC. I've crafted a fix and I should be able to push out a release in the next couple days

@Sveske-Juice
Copy link
Contributor Author

Great, that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants