Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap to reveal overflown exercise name #241

Closed
LiamMorrow opened this issue Aug 8, 2024 · 4 comments
Closed

tap to reveal overflown exercise name #241

LiamMorrow opened this issue Aug 8, 2024 · 4 comments

Comments

@LiamMorrow
Copy link
Owner

Exercise names can overflow and be truncated with an elipsis... Tapping them should reveal them somehow. Thinking either tooltip, or potentially scrolling like a music player?

@cannontrodder
Copy link
Contributor

My issue with the overflow is it hides the history icon which I find crucial for making decisions on tweaking things!

@LiamMorrow
Copy link
Owner Author

LiamMorrow commented Oct 1, 2024

Thanks for letting me know! It definitely shouldn't be doing that, and I can't reproduce it. 🤔 Are you on iphone or android?

The history button does hide itself when you have never done that exercise before (exact same amount of sets / reps/ exact name). Is is possible this is the cause of it hiding? I've been moving to a more loose model, so I think I could start showing it all the time.

I've since merged:
#280

This will show history even if the number of reps/sets is different.

@cannontrodder
Copy link
Contributor

This is almost certainly to because I edited the exercise (added a set)!

@LiamMorrow
Copy link
Owner Author

That's good to know :) That change to show other anything with the same name in the previous view is now live on Android (having trouble with iOS builds rn)

@LiamMorrow LiamMorrow closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants