Skip to content

Commit

Permalink
Merge pull request #306 from LiamMorrow/fix-ios-build-2
Browse files Browse the repository at this point in the history
  • Loading branch information
LiamMorrow authored Oct 28, 2024
2 parents d3a049b + d00273e commit 57733cf
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
3 changes: 2 additions & 1 deletion LiftLog.Maui/LiftLog.Maui.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<TargetFrameworks>net8.0-android</TargetFrameworks>

<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('osx'))">$(TargetFrameworks);net8.0-ios18;</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('osx'))">$(TargetFrameworks);net8.0-ios;</TargetFrameworks>

<OutputType>Exe</OutputType>
<RootNamespace>LiftLog.Maui</RootNamespace>
Expand Down Expand Up @@ -75,6 +75,7 @@
<PropertyGroup Condition="$(TargetFramework.Contains('-ios')) and '$(Configuration)' == 'Release'">
<MtouchLink>SdkOnly</MtouchLink>
<UseInterpreter>True</UseInterpreter>
<_ExportSymbolsExplicitly>false</_ExportSymbolsExplicitly>
</PropertyGroup>

<ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
Expand Down
8 changes: 0 additions & 8 deletions LiftLog.Maui/Properties/launchSettings.json

This file was deleted.

8 changes: 7 additions & 1 deletion LiftLog.Ui/Shared/Smart/AppReviewRequest.razor
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<span slot="content" class="block text-left">If so, would you take a minute to leave a @ReviewType on @AppStore?</span>
<div slot="actions" class="flex">
<AppButton Type="AppButtonType.Text" class="mr-auto" OnClick="Never">Never</AppButton>
<AppButton Type="AppButtonType.Text" OnClick="()=>rateDialog?.Close()">Not Now</AppButton>
<AppButton Type="AppButtonType.Text" OnClick="NotNow">Not Now</AppButton>
@if(DeviceService.GetDeviceType() == DeviceType.Web)
{
<AppButton Type="AppButtonType.Text" OnClick="Rate" target="_blank" href="https://github.com/LiamMorrow/LiftLog">Rate</AppButton>
Expand Down Expand Up @@ -44,6 +44,12 @@
rateDialog?.Close();
}

private void NotNow()
{
Dispatcher.Dispatch(new SetAppLaunchCountAction(0));
rateDialog?.Close();
}

private void Rate()
{
Dispatcher.Dispatch(new SetAppRatingResultAction(AppRatingResult.Rated));
Expand Down

0 comments on commit 57733cf

Please sign in to comment.