Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small visual inconsistencies and suggestions #2

Open
sans-c opened this issue Nov 27, 2024 · 2 comments
Open

small visual inconsistencies and suggestions #2

sans-c opened this issue Nov 27, 2024 · 2 comments

Comments

@sans-c
Copy link

sans-c commented Nov 27, 2024

Hi there, first of all: thank you for this amazing analysis feature! It's really quite something to see what one of the strongest public lc0-instances has to say on world class matches. :)

As for the issues:

  1. the eval bar on the left slightly protrudes the bottom edge of the board with its drop shadow obscuring whites clock a little bit.
  2. the dashed move markers for opponents moves are layered on top of the piece they originate from (see rook on h8 and bishop on c2). Maybe this is intentional for better visibility? I just noticed that the main move arrows are actually below the starting piece.

And for the suggestions:

  1. Once again, this might be intentional, but in the move list the move which is not yet played is highlighted which - at least to me - is a bit confusing. In the screenshot the line beneath Nbd7 is highlighted, eventhough the last move was Nbd7. It makes sense in a way but still might be worth to reconsider.
  2. Maybe work on a "dark mode"? :) The current version looks very clean and quite pleasing but also might burn your eyes later in the evening.

image

@mooskagh
Copy link
Member

mooskagh commented Nov 27, 2024

  1. Yeah I know, couldn't fix it within 10 minutes of messing up with CSS (while keeping the board adapt to a mobile screen).

  2. Yeah, ideally it would be good to start arrows below the pieces and go above all other pieces, but it requires some object ordering loging that I dind't have time to implement (and not always possible). Currently it "approximates" the ordering but drawing in this order: opponent's pieces, then solid arrows, then side-to-move's pieces, then all other arrows.


  1. What you describe is how it worked initially, and some people wanted to do it more TCEC-like, so I changed that. One benefit of the current view is that when you click on one of the previous moves, the "move actually played" highlight is consistent with whatever is highlighted on the movelist.

  2. I assumed people would watch WCC in the morning. :-P But really, there are other important features which are missing (like board flip, controlling number of arrows etc), and there's no "settings" (I didn't find a good place for them in the UI) -- so maybe later dark mode will be there, but certainly not the first thing to work on.

@mooskagh
Copy link
Member

ok dark mode is there :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants