Assert Heap Size #200
Assert Heap Size #200
Conversation
|
Hey @yogh333! Any reason why this check was added? It is quite inconvenient in cases where there is a limited size between stack and heap. Between 8192, and 16384 there is a big gap, and could potentially block apps where the stack is important too. |
|
Particularly, this could break the Ironfish DKG app that we are currently reviewing on ledger side. It is not enough with 8192, and 16384 is too much. We were using something in between (16300), and the app was working just fine. |
|
This PR increases the stack usage on 359 bytes (because of the warning icon), and that breaks our app. We cannot decrease the heap size a bit, and 8192 is not enough. :/ |
|
@emmanuelm41 You are right, I have modified the assert in this PR #209 |
|
@yogh333 thanks a lot for the quick fix. I think it will work now!! Again, thanks! |
No description provided.