Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some new features #193

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Some new features #193

merged 3 commits into from
Sep 30, 2024

Conversation

emmanuelm41
Copy link
Contributor

@emmanuelm41 emmanuelm41 commented Sep 27, 2024 •
edited
Loading

  • allow to choose light review or not
  • create new page style

@yogh333 yogh333 self-requested a review September 27, 2024 15:21
yogh333
yogh333 reviewed Sep 27, 2024
View reviewed changes
ledger_secure_sdk_sys/build.rs Outdated Show resolved Hide resolved
ledger_secure_sdk_sys/build.rs Outdated Show resolved Hide resolved
@emmanuelm41 emmanuelm41 requested a review from yogh333 September 27, 2024 15:52
yogh333
yogh333 requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the modifications in build.rs

@emmanuelm41 emmanuelm41 requested a review from yogh333 September 27, 2024 17:07
@yogh333 yogh333 merged commit 1dfd4c5 into LedgerHQ:master Sep 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogh333 yogh333 yogh333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuelm41 @yogh333